Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download handler on schema tests #540

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix download handler on schema tests #540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions schema/schemas_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,12 @@ func downloadFromSchemaStore(t *testing.T, schema string) gojsonschema.JSONLoade
ExecutionHandler: func() (bool, error) {
response, err = http.Get("https://json.schemastore.org/" + schema)
if err != nil {
return false, err
return true, err
}
if response.StatusCode != http.StatusOK {
return false, fmt.Errorf("failed to download schema. Response status: %s", response.Status)
return true, fmt.Errorf("failed to download schema. Response status: %s", response.Status)
}
return true, nil
return false, nil
},
}
assert.NoError(t, retryExecutor.Execute())
Expand Down
Loading