Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM scan repository pushes node_modules into PR fix #551

Merged
merged 13 commits into from
Oct 29, 2023
Merged

NPM scan repository pushes node_modules into PR fix #551

merged 13 commits into from
Oct 29, 2023

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Oct 24, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

node_modules files are no longer being pushed into the fixed PR if they weren't exist in the project's dir before initiating the fix.
For a project without node_modules the only files that are pushed now into the PR upon fix are:
updated package.json
package-lock.json

@eranturgeman eranturgeman temporarily deployed to frogbot October 24, 2023 10:01 — with GitHub Actions Inactive
@eranturgeman eranturgeman added bug Something isn't working safe to test Approve running integration tests on a pull request labels Oct 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot October 24, 2023 10:03 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@eranturgeman eranturgeman requested a review from omerzi October 24, 2023 10:04
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot October 24, 2023 11:29 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot October 25, 2023 06:47 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@eranturgeman eranturgeman requested review from attiasas and eyalbe4 and removed request for omerzi October 26, 2023 07:38
@eranturgeman eranturgeman changed the title Bug fix: NPM scan repository pushes node_modules into PR NPM scan repository pushes node_modules into PR fix Oct 26, 2023
@eranturgeman eranturgeman requested a review from yahavi October 26, 2023 13:09
@eranturgeman eranturgeman temporarily deployed to frogbot October 26, 2023 13:09 — with GitHub Actions Inactive
@eranturgeman eranturgeman temporarily deployed to frogbot October 26, 2023 13:14 — with GitHub Actions Inactive
yahavi
yahavi requested changes Oct 26, 2023
View reviewed changes
packagehandlers/npmpackagehandler.go Outdated Show resolved Hide resolved
@eranturgeman eranturgeman temporarily deployed to frogbot October 26, 2023 13:50 — with GitHub Actions Inactive
@eranturgeman eranturgeman temporarily deployed to frogbot October 26, 2023 13:54 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Oct 26, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 26, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot October 29, 2023 07:53 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Oct 29, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 29, 2023
@github-actions
Copy link
Contributor

@eranturgeman eranturgeman merged commit 1a1004f into jfrog:dev Oct 29, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @yahavi