Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New variable for adding pull request comment title #556

Merged
merged 13 commits into from
Oct 25, 2023
Merged

New variable for adding pull request comment title #556

merged 13 commits into from
Oct 25, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Oct 25, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@omerzi omerzi added safe to test Approve running integration tests on a pull request new feature Automatically generated release notes labels Oct 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 25, 2023
eyalbe4
eyalbe4 requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the new variables to all the workflow templates in the documentation.

schema/frogbot-schema.json Outdated Show resolved Hide resolved
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited by attiasas
Loading

teststests

@omerzi omerzi merged commit 5d0e9da into jfrog:dev Oct 25, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerzi @eyalbe4