Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable Jas scans #776

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Add option to disable Jas scans #776

merged 4 commits into from
Oct 29, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Oct 29, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

Add option in config (disableJas)/ env var (JF_DISABLE_ADVANCED_SECURITY) to disable JAS scans

@attiasas attiasas added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Oct 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 29, 2024
hadarshjfrog
hadarshjfrog reviewed Oct 29, 2024
View reviewed changes
utils/consts.go Outdated Show resolved Hide resolved
hadarshjfrog
hadarshjfrog approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@hadarshjfrog hadarshjfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested to change to "advanced security"

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 29, 2024
hadarshjfrog
hadarshjfrog reviewed Oct 29, 2024
View reviewed changes
utils/scandetails.go Outdated Show resolved Hide resolved
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 29, 2024
@attiasas attiasas merged commit 6964eab into jfrog:dev Oct 29, 2024
32 of 33 checks passed
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadarshjfrog hadarshjfrog hadarshjfrog approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @hadarshjfrog