Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package manager login command - Docker, Podman #1304

Merged
merged 66 commits into from
Dec 28, 2024
Merged
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
bb36015
Improve repositores code
sverdlov93 Oct 25, 2024
6583684
Improve repositores code
sverdlov93 Oct 25, 2024
fb20e20
Improve repositores code
sverdlov93 Oct 27, 2024
9a20c6c
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into np…
sverdlov93 Oct 29, 2024
ed7b39d
Improve repositores code
sverdlov93 Oct 30, 2024
633d8a0
Improve repositores code
sverdlov93 Nov 3, 2024
74c9a47
Improve repositores code
sverdlov93 Nov 3, 2024
e0e5024
Improve repositores code
sverdlov93 Nov 4, 2024
f51ae6d
Improve repositores code
sverdlov93 Nov 4, 2024
7233563
Merge branch 'dev' into npm-login
sverdlov93 Nov 5, 2024
f8e793a
Improve repositores code
sverdlov93 Nov 6, 2024
c53b4c2
Merge branch 'npm-login' of https://github.com/sverdlov93/jfrog-cli-c…
sverdlov93 Nov 6, 2024
c3e0486
Improve repositores code
sverdlov93 Nov 6, 2024
e8cc9f8
Improve repositores code
sverdlov93 Nov 6, 2024
95ba696
Improve repositores code
sverdlov93 Nov 6, 2024
3dff2bb
Improve repositores code
sverdlov93 Nov 6, 2024
0f0856e
Improve repositores code
sverdlov93 Nov 6, 2024
f280aa5
Improve repositores code
sverdlov93 Nov 6, 2024
ecb74bb
Improve repositores code
sverdlov93 Nov 6, 2024
cd0fda3
Improve repositores code
sverdlov93 Nov 6, 2024
547fa02
Improve repositores code
sverdlov93 Nov 6, 2024
265fea7
Improve repositores code
sverdlov93 Nov 6, 2024
e8f884c
Improve repositores code
sverdlov93 Nov 7, 2024
2ee5950
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into np…
sverdlov93 Nov 7, 2024
aec982a
Improve repositores code
sverdlov93 Nov 7, 2024
57df296
Improve repositores code
sverdlov93 Nov 7, 2024
e8d5842
Improve repositores code
sverdlov93 Nov 7, 2024
f84e6f8
Improve repositores code
sverdlov93 Nov 7, 2024
8c2b1c6
Merge branch 'dev' into npm-login
sverdlov93 Nov 10, 2024
e6afac1
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into np…
sverdlov93 Nov 10, 2024
f6eed54
Merge branch 'dev' into npm-login
sverdlov93 Nov 11, 2024
be5cdcb
Improve upload archive progress bar
sverdlov93 Nov 11, 2024
1087833
Merge remote-tracking branch 'sverdlov93/npm-login' into npm-login
sverdlov93 Nov 11, 2024
cd0ce91
Improve upload archive progress bar
sverdlov93 Nov 11, 2024
31b0627
Improve upload archive progress bar
sverdlov93 Nov 11, 2024
89cdb97
Improve upload archive progress bar
sverdlov93 Nov 11, 2024
02252d2
Improve upload archive progress bar
sverdlov93 Nov 11, 2024
76fd3b4
Improve upload archive progress bar
sverdlov93 Nov 11, 2024
77e8d71
Improve upload archive progress bar
sverdlov93 Nov 12, 2024
f28f014
Improve upload archive progress bar
sverdlov93 Nov 12, 2024
0e959a3
Improve upload archive progress bar
sverdlov93 Nov 12, 2024
01e0f45
Improve upload archive progress bar
sverdlov93 Nov 12, 2024
95bf72e
Improve upload archive progress bar
sverdlov93 Nov 12, 2024
c90cbb3
Improve upload archive progress bar
sverdlov93 Nov 12, 2024
5f37066
Improve upload archive progress bar
sverdlov93 Nov 12, 2024
1ecb8ed
Improve upload archive progress bar
sverdlov93 Nov 12, 2024
6e3f8b9
Improve upload archive progress bar
sverdlov93 Nov 17, 2024
07af542
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into np…
sverdlov93 Nov 17, 2024
746d67d
Improve upload archive progress bar
sverdlov93 Nov 20, 2024
5f8e0aa
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into np…
sverdlov93 Nov 20, 2024
43d1a80
Improve upload archive progress bar
sverdlov93 Nov 21, 2024
3f8ab57
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into np…
sverdlov93 Dec 16, 2024
b73d2eb
Merge branch 'dev' into npm-login
sverdlov93 Dec 22, 2024
0d5e16b
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into np…
sverdlov93 Dec 22, 2024
bc7f2d4
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into np…
sverdlov93 Dec 24, 2024
6e5def8
Improve upload archive progress bar
sverdlov93 Dec 24, 2024
a89e2f5
Improve upload archive progress bar
sverdlov93 Dec 24, 2024
e8566f1
Merge remote-tracking branch 'sverdlov93/npm-login' into npm-login
sverdlov93 Dec 24, 2024
3a1bcf0
Improve upload archive progress bar
sverdlov93 Dec 25, 2024
52894c8
Improve upload archive progress bar
sverdlov93 Dec 25, 2024
3a0f99b
Merge branch 'dev' into npm-login
sverdlov93 Dec 25, 2024
70015a8
Merge branch 'dev' into npm-login
sverdlov93 Dec 26, 2024
dc79716
Improve upload archive progress bar
sverdlov93 Dec 26, 2024
4355159
Merge remote-tracking branch 'sverdlov93/npm-login' into npm-login
sverdlov93 Dec 26, 2024
4908ff5
Improve upload archive progress bar
sverdlov93 Dec 26, 2024
84f28a3
Merge branch 'dev' into npm-login
sverdlov93 Dec 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve repositores code
Signed-off-by: Michael Sverdlov <[email protected]>
sverdlov93 committed Nov 6, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit c3e0486e10642f69dfa914786efda28137fd4a3e
2 changes: 1 addition & 1 deletion artifactory/commands/buildtoollogin/buildtoollogin.go
Original file line number Diff line number Diff line change
@@ -125,7 +125,7 @@ func (btlc *BuildToolLoginCommand) configurePip() error {
if err != nil {
return err
}
return pythoncommands.RunConfigCommand(btlc.buildTool, []string{"set", "global.index-url", repoWithCredsUrl})
return pythoncommands.RunConfigCommand(project.Pip, []string{"set", "global.index-url", repoWithCredsUrl})
}

// configurePoetry configures Poetry to use the specified repository and authentication credentials.
2 changes: 1 addition & 1 deletion artifactory/commands/buildtoollogin/buildtoollogin_test.go
Original file line number Diff line number Diff line change
@@ -134,7 +134,7 @@ func TestBuildToolLoginCommand_Yarn(t *testing.T) {
} else if testCase.user != "" && testCase.password != "" {
// Validate basic authentication with encoded credentials.
// Base64 encoding of "myUser:myPassword"
assert.Contains(t, yarnrcContent, fmt.Sprintf("\"//acme.jfrog.io/artifactory/api/npm/test-repo:%s\"bXlVc2VyOm15UGFzc3dvcmQ=", cmdutils.NpmConfigAuthKey))
assert.Contains(t, yarnrcContent, fmt.Sprintf("\"//acme.jfrog.io/artifactory/api/npm/test-repo:%s\" bXlVc2VyOm15UGFzc3dvcmQ=", cmdutils.NpmConfigAuthKey))
}

// Clean up the temporary npmrc file.

Unchanged files with check annotations Beta

}
// Helper function to set up the BuildToolLogin.
func setupNpmrcManager(buildTool project.ProjectType) *BuildToolLogin {

Check failure on line 85 in artifactory/commands/utils/npmcmdutils_test.go

GitHub Actions / Go-Sec

undefined: BuildToolLogin

Check failure on line 85 in artifactory/commands/utils/npmcmdutils_test.go

GitHub Actions / Static-Check

undefined: BuildToolLogin
serverDetails := &config.ServerDetails{
ArtifactoryUrl: testArtifactoryUrl,
}
return NewNpmrcYarnrcManager(buildTool, "my-repo-virtual", serverDetails)

Check failure on line 89 in artifactory/commands/utils/npmcmdutils_test.go

GitHub Actions / Go-Sec

undefined: NewNpmrcYarnrcManager

Check failure on line 89 in artifactory/commands/utils/npmcmdutils_test.go

GitHub Actions / Static-Check

undefined: NewNpmrcYarnrcManager (typecheck)
}
// Helper function to create a temporary .npmrc file for isolated tests.