Merge pull request #95 from jfrog/improve-github-workflow

Back port improvements & fixes from Artifactory provider

.github/workflows/acceptance-tests.yml

@@ -13,14 +13,14 @@ jobs:
   acceptance-tests-matrix:
     name: ${{ matrix.cli }}
     runs-on: ubuntu-latest
-    continue-on-error: true
+    continue-on-error: false
     environment: development
     strategy:
       fail-fast: true
       matrix:
         cli: [terraform, tofu]
     outputs:
-      tf_version: ${{ steps.debug_tf_version.outputs.version }}
+      tf_version: ${{ steps.install_terraform_cli.outputs.version }}
       tofu_version: ${{ steps.install_opentofu_cli.outputs.version }}
       artifactory_version: ${{ steps.run_artifactory_container.outputs.version }}
     steps:
@@ -139,11 +139,11 @@ jobs:
           cat sample.tf | sed -e "s/version =.*/version = \"${PROVIDER_VERSION}\"/g" > sample.tf.tmp
           cp sample.tf.tmp sample.tf && rm sample.tf.tmp
           TERRAFORM_CLI=${{ matrix.cli }} make install
-      - name: Dump Artifactory logs
-        uses: jwalton/gh-docker-logs@v2
-        if: failure()
-        with:
-          tail: '10000'
+      # - name: Dump Artifactory logs
+      #   uses: jwalton/gh-docker-logs@v2
+      #   if: failure()
+      #   with:
+      #     tail: '10000'
       - name: Clean up Docker container
         if: always()
         run: docker stop artifactory
@@ -171,7 +171,7 @@ jobs:
   update-changelog:
     runs-on: ubuntu-latest
     needs: acceptance-tests-matrix
-    if: ${{ github.event_name == 'pull_request' && needs.acceptance-tests-matrix.result == 'success' }}
+    if: ${{ github.event_name == 'pull_request' }} && ${{ needs.acceptance-tests-matrix.result == 'success' }}
     permissions:
       contents: write
     steps: