feat: new modules (prettier/status-reporter) to demonstrate how to add npm and java dependencies #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murdos
commented
Sep 17, 2024
| //@formatter:off | ||
| return moduleBuilder(properties) | ||
| .packageJson() | ||
| .addDevDependency(packageName("prettier-plugin-properties"), PRETTIER) |
There was a problem hiding this comment.
Here we're using a custom npm source, that is defined in the custom extension: JhliteExtensionNpmVersionSource.PRETTIER
...extension/shared/npm/infrastructure/secondary/JhliteExtensionFileSystemNpmVersionReader.java
Outdated
Show resolved
Hide resolved
murdos
force-pushed
the
poc-npm-version-source
branch
2 times, most recently
from
ac394d3 to
288438a
Compare
murdos
changed the title
murdos
force-pushed
the
poc-npm-version-source
branch
2 times, most recently
from
75a3066 to
c223a11
Compare
murdos
force-pushed
the
poc-npm-version-source
branch
from
c223a11 to
123f126
Compare
|
@pascalgrimaud : do you agree to include these additional modules, that will serve as examples on how to manipulate custom npm or maven dependencies? |
|
Yes it's a good idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent is to demonstrate how to declare and use npm dependencies that are not declared in jhipster-lite