More scrubbing of malspelled names.

The addition of a linter rules for ifid and trc has revealed a truckload more.
Some *cannot* be fixed as they are automatically derived from published
APIs and Protobufs.

control/beaconing/writer_test.go

@@ -390,7 +390,7 @@ func interfaceInfos(topo topology.Topology) map[uint16]ifstate.InterfaceInfo {
 			IA:           info.IA,
 			LinkType:     info.LinkType,
 			InternalAddr: netip.MustParseAddrPort(info.InternalAddr.String()),
-			RemoteID:     uint16(info.RemoteIFID),
+			RemoteID:     uint16(info.RemoteIfID),
 			MTU:          uint16(info.MTU),
 		}
 	}

control/cmd/control/main.go

@@ -852,7 +852,7 @@ func adaptInterfaceMap(in map[common.IfIDType]topology.IFInfo) map[uint16]ifstat
 			IA:           info.IA,
 			LinkType:     info.LinkType,
 			InternalAddr: info.InternalAddr,
-			RemoteID:     uint16(info.RemoteIFID),
+			RemoteID:     uint16(info.RemoteIfID),
 			MTU:          uint16(info.MTU),
 		}
 	}

control/mgmtapi/api.go

@@ -586,22 +586,26 @@ func (s *Server) GetCa(w http.ResponseWriter, r *http.Request) {
 }
 
 // GetTrcs gets the trcs specified by it's params.
-func (s *Server) GetTrcs(w http.ResponseWriter, r *http.Request, params GetTrcsParams) {
-	cppkiParams := cppkiapi.GetTrcsParams{
+func (s *Server) GetTrcs(
+	w http.ResponseWriter,
+	r *http.Request,
+	params GetTrcsParams, // nolint - name from published API
+) {
+	cppkiParams := cppkiapi.GetTrcsParams{ // nolint - name from published API
 		Isd: params.Isd,
 		All: params.All,
 	}
-	s.CPPKIServer.GetTrcs(w, r, cppkiParams)
+	s.CPPKIServer.GetTrcs(w, r, cppkiParams) // nolint - name from published API
 }
 
 // GetTrc gets the trc specified by it's isd base and serial.
 func (s *Server) GetTrc(w http.ResponseWriter, r *http.Request, isd int, base int, serial int) {
-	s.CPPKIServer.GetTrc(w, r, isd, base, serial)
+	s.CPPKIServer.GetTrc(w, r, isd, base, serial) // nolint - name from published API
 }
 
 // GetTrcBlob gets the trc encoded pem blob.
 func (s *Server) GetTrcBlob(w http.ResponseWriter, r *http.Request, isd int, base int, serial int) {
-	s.CPPKIServer.GetTrcBlob(w, r, isd, base, serial)
+	s.CPPKIServer.GetTrcBlob(w, r, isd, base, serial) // nolint - name from published API
 }
 
 // GetConfig is an indirection to the http handler.
@@ -663,12 +667,12 @@ func (s *Server) GetSigner(w http.ResponseWriter, r *http.Request) {
 			},
 		},
 		Expiration: p.Expiration,
-		TrcId: TRCID{
+		TrcId: TRCID{ // nolint - name from published API
 			BaseNumber:   int(p.TRCID.Base),
 			Isd:          int(p.TRCID.ISD),
 			SerialNumber: int(p.TRCID.Serial),
 		},
-		TrcInGracePeriod: p.InGrace,
+		TrcInGracePeriod: p.InGrace, // nolint - name from published API
 	}
 	enc := json.NewEncoder(w)
 	enc.SetIndent("", "    ")

control/trust/grpc/proto.go

@@ -86,6 +86,6 @@ func chainsToResponse(chains [][]*x509.Certificate) *cppb.ChainsResponse {
 
 func trcToResponse(trc cppki.SignedTRC) *cppb.TRCResponse {
 	return &cppb.TRCResponse{
-		Trc: trc.Raw,
+		Trc: trc.Raw, // nolint - name from protobuf
 	}
 }

control/trust/grpc/proto_test.go

@@ -150,5 +150,5 @@ func TestChainsToRep(t *testing.T) {
 func TestTRCToRep(t *testing.T) {
 	trc := cppki.SignedTRC{Raw: []byte("you can trust me, for sure!")}
 	rep := trustgrpc.TRCToResponse(trc)
-	assert.Equal(t, trc.Raw, rep.Trc)
+	assert.Equal(t, trc.Raw, rep.Trc) // nolint - name from published protobuf
 }

daemon/internal/servers/grpc.go

@@ -47,7 +47,7 @@ import (
 )
 
 type Topology interface {
-	InterfaceIDs() []uint16
+	IfIDs() []uint16
 	UnderlayNextHop(uint16) *net.UDPAddr
 	ControlServiceAddresses() []*net.UDPAddr
 	PortRange() (uint16, uint16)
@@ -277,7 +277,7 @@ func (s *DaemonServer) interfaces(ctx context.Context,
 		Interfaces: make(map[uint64]*sdpb.Interface),
 	}
 	topo := s.Topology
-	for _, ifID := range topo.InterfaceIDs() {
+	for _, ifID := range topo.IfIDs() {
 		nextHop := topo.UnderlayNextHop(ifID)
 		if nextHop == nil {
 			continue

daemon/mgmtapi/api.go

@@ -102,20 +102,24 @@ func (s *Server) GetCertificateBlob(w http.ResponseWriter, r *http.Request, chai
 }
 
 // GetTrcs gets the trcs specified by it's params.
-func (s *Server) GetTrcs(w http.ResponseWriter, r *http.Request, params GetTrcsParams) {
-	cppkiParams := cppkiapi.GetTrcsParams{
+func (s *Server) GetTrcs(
+	w http.ResponseWriter,
+	r *http.Request,
+	params GetTrcsParams, // nolint - name from published API
+) {
+	cppkiParams := cppkiapi.GetTrcsParams{ // nolint - name from published API
 		Isd: params.Isd,
 		All: params.All,
 	}
-	s.CPPKIServer.GetTrcs(w, r, cppkiParams)
+	s.CPPKIServer.GetTrcs(w, r, cppkiParams) // nolint - name from published API
 }
 
 // GetTrc gets the trc specified by it's isd base and serial.
 func (s *Server) GetTrc(w http.ResponseWriter, r *http.Request, isd int, base int, serial int) {
-	s.CPPKIServer.GetTrc(w, r, isd, base, serial)
+	s.CPPKIServer.GetTrc(w, r, isd, base, serial) // nolint - name from published API
 }
 
 // GetTrcBlob gets the trc encoded pem blob.
 func (s *Server) GetTrcBlob(w http.ResponseWriter, r *http.Request, isd int, base int, serial int) {
-	s.CPPKIServer.GetTrcBlob(w, r, isd, base, serial)
+	s.CPPKIServer.GetTrcBlob(w, r, isd, base, serial) // nolint - name from published API
 }

pkg/experimental/hiddenpath/beaconwriter_test.go

@@ -369,7 +369,7 @@ func interfaceInfos(topo topology.Topology) map[uint16]ifstate.InterfaceInfo {
 			IA:           info.IA,
 			LinkType:     info.LinkType,
 			InternalAddr: netip.MustParseAddrPort(info.InternalAddr.String()),
-			RemoteID:     uint16(info.RemoteIFID),
+			RemoteID:     uint16(info.RemoteIfID),
 			MTU:          uint16(info.MTU),
 		}
 	}