Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

Feature: Tooltips #72

Merged
merged 7 commits into from
Nov 11, 2020
Merged

Feature: Tooltips #72

merged 7 commits into from
Nov 11, 2020

Conversation

BastinJafari
Copy link
Contributor

image

This implements tooltips from the pull request about tooltips on Mr. Blenny's flow chart library:

MrBlenny/react-flow-chart#217

Tooltips are useful to communicate the handling of the flow charts to the end-user.
For example, if the ability to select multiple flowcharts gets implemented, a tooltip could inform the user about this possibility

@BastinJafari BastinJafari changed the title Add tooltips Feature: Tooltips Nov 1, 2020
@nan-wang
Copy link
Member

nan-wang commented Nov 3, 2020

hi, @BastinJafari Thanks for your PR. There are some conflicts with the master. Would you please take a look and resolve them?

@BastinJafari
Copy link
Contributor Author

Resolved merge conflicts

@nan-wang
Copy link
Member

nan-wang commented Nov 6, 2020

@BastinJafari hmmm, new conflicts arrive.

yarn.lock Outdated
@@ -0,0 +1,13514 @@
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #32, this project started using npm over yarn.

So, having yarn.lock file could be confusing for contributors. Please remove it.

@BastinJafari
Copy link
Contributor Author

I resolved all conflicts and integrated the multi-select-change by publishing a new npm package with the tooltip and the multi-select feature and deleted yarn.lock

@imsergiy imsergiy merged commit 535cba7 into jina-ai:master Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants