This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi, @BastinJafari Thanks for your PR. There are some conflicts with the master. Would you please take a look and resolve them? |
BastinJafari
force-pushed
the
add-tooltips
branch
from
November 5, 2020 09:30
b867afe
to
518edf2
Compare
Resolved merge conflicts |
@BastinJafari hmmm, new conflicts arrive. |
Roshanjossey
reviewed
Nov 8, 2020
yarn.lock
Outdated
@@ -0,0 +1,13514 @@ | |||
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With #32, this project started using npm
over yarn
.
So, having yarn.lock
file could be confusing for contributors. Please remove it.
merge master
The current linter configuration can't read css and scss files properly
BastinJafari
force-pushed
the
add-tooltips
branch
from
November 10, 2020 21:58
518edf2
to
14d4268
Compare
I resolved all conflicts and integrated the multi-select-change by publishing a new npm package with the tooltip and the multi-select feature and deleted yarn.lock |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements tooltips from the pull request about tooltips on Mr. Blenny's flow chart library:
MrBlenny/react-flow-chart#217
Tooltips are useful to communicate the handling of the flow charts to the end-user.
For example, if the ability to select multiple flowcharts gets implemented, a tooltip could inform the user about this possibility