Fix JS error - incorrect questionid #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nexterday
reviewed
Sep 23, 2019
| @@ -16,7 +16,7 @@ YUI.add('moodle-qtype_ddmatch-dragdrop', function(Y, NAME) { | |||
| return; | |||
| } | |||
|
|
|||
| var containerid = 'div#q' + this.get('questionid'), | |||
| var containerid = 'div#' + this.get('questionid'), | |||
There was a problem hiding this comment.
The new question div ids for 3.7 are compound of 'question-' . $this->usageid . '-' . $this->slot; see
/**
* When the question is rendered, this unique id is added to the
* outer div of the question. It can be used to uniquely reference
* the question from JavaScript.
*
* @return string id added to the outer <div class="que ..."> when the question is rendered.
*/
public function get_outer_question_div_unique_id() {
return 'question-' . $this->usageid . '-' . $this->slot;
}
There was a problem hiding this comment.
Thank you for the update! (@nexterday )
There was a problem hiding this comment.
It’s still working in Moodle 3.9.
Thanks a lot!
There was a problem hiding this comment.
Hello, sorry but I am now retired and stopped all programming work. Feel free to fork this repository and make any change you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this question type work in Moodle 3.7