Fix valkey-io#5 - Consider adding older engine versions (like 7.2)

joehu21 · Dec 10, 2024 · 06ffb50 · 06ffb50
1 parent 68dbc54
commit 06ffb50
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -8,7 +8,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        server_version: ['unstable', '8.0.0']
+        server_version: ['unstable', '8.0', '7.2']
     steps:
     - uses: actions/checkout@v4
     - name: Set the server version for python integration tests

diff --git a/README.md b/README.md
@@ -14,8 +14,8 @@ ValkeyJSON leverages [RapidJSON](https://rapidjson.org/), a high-performance JSO
 
 The default valkey version is "unstable". To override it, do:
 ```text
-# Build valkey-server (8.0.0) and run integration tests
-SERVER_VERSION=8.0.0 ./build.sh
+# Build valkey-server (8.0) and run integration tests
+SERVER_VERSION=8.0 ./build.sh
 ```
 
 Custom compiler flags can be passed to the build script via environment variable CFLAGS. For example:
@@ -35,7 +35,7 @@ The default valkey version is "unstable". To override it, do:
 ```text
 mdkir build
 cd build
-cmake .. -DVALKEY_VERSION=8.0.0
+cmake .. -DVALKEY_VERSION=8.0
 make
 ```