Merge pull request #160 from vercellone/pestermock

Foundational Pester unit tests for #35

F5-LTM/F5-LTM.psm1

@@ -18,31 +18,28 @@ Add-Type -Path "${PSScriptRoot}\Validation.cs"
 Add-Type -Path "${PSScriptRoot}\TypeData\PoshLTM.Types.cs"
 Update-FormatData "${PSScriptRoot}\TypeData\PoshLTM.Format.ps1xml"
 $ScriptPath = Split-Path $MyInvocation.MyCommand.Path
-
 #region Load Public Functions
 
-try {
     Get-ChildItem "$ScriptPath\Public" -Filter *.ps1 -Recurse| Select-Object -Expand FullName | ForEach-Object {
         $Function = Split-Path $_ -Leaf
-        . $_
-    }
-} catch {
-    Write-Warning ("{0}: {1}" -f $Function,$_.Exception.Message)
-    Continue
-}
+        try {
+            . $_
+        } catch {
+            Write-Warning ("{0}: {1}" -f $Function,$_.Exception.Message)
+        }
+   }
 
 #endregion
 
 #region Load Private Functions
 
-try {
-   Get-ChildItem "$ScriptPath\Private" -Filter *.ps1 -Recurse | Select-Object -Expand FullName | ForEach-Object {
-       $Function = Split-Path $_ -Leaf
-       . $_
-   }
-} catch {
-   Write-Warning ("{0}: {1}" -f $Function,$_.Exception.Message)
-   Continue
-}
+    Get-ChildItem "$ScriptPath\Private" -Filter *.ps1 -Recurse | Select-Object -Expand FullName | ForEach-Object {
+        $Function = Split-Path $_ -Leaf
+        try {
+            . $_
+        } catch {
+            Write-Warning ("{0}: {1}" -f $Function,$_.Exception.Message)
+        }
+    }
 
 #endregion

F5-LTM/Private/Resolve-NestedStats.ps1

@@ -6,7 +6,7 @@
  
     To resolve this discrepancy, this function performs version-specific transformations to the JSON data and returns it in a standardized format with the "entries" property at the top.
 #>
-
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSUseSingularNouns", "")]
     param (
         $F5Session=$Script:F5Session,
 

F5-LTM/Public/Disable-VirtualServer.ps1

@@ -32,7 +32,7 @@
                 foreach($vs in $InputObject) {
                     $URI = $F5Session.GetLink($vs.selfLink)
                     $FullPath = $vs.fullPath
-                    $JSON = Invoke-F5RestMethod -Method PATCH -Uri $URI -F5Session $F5Session -Body $JSONBody
+                    $null = Invoke-F5RestMethod -Method PATCH -Uri $URI -F5Session $F5Session -Body $JSONBody
                     Get-VirtualServer -F5Session $F5Session -Name $FullPath
                 }
             }

F5-LTM/Public/Enable-VirtualServer.ps1

@@ -32,7 +32,7 @@
                 foreach($vs in $InputObject) {
                     $URI = $F5Session.GetLink($vs.selfLink)
                     $FullPath = $vs.fullPath
-                    $JSON = Invoke-F5RestMethod -Method PATCH -Uri $URI -F5Session $F5Session -Body $JSONBody
+                    $null = Invoke-F5RestMethod -Method PATCH -Uri $URI -F5Session $F5Session -Body $JSONBody
                     Get-VirtualServer -F5Session $F5Session -Name $FullPath
                 }
             }

F5-LTM/Public/Get-PoolMemberStats.ps1

@@ -6,6 +6,7 @@
     Pool and member names are case-specific.
 #>
     [cmdletBinding()]
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSUseSingularNouns", "")]
     param (
         $F5Session=$Script:F5Session,
 

F5-LTM/Public/Set-Pool.ps1

@@ -124,10 +124,10 @@
 
         # This performs the magic necessary for ChgProperties to override $InputObject properties
         $NewObject = Join-Object -Left $InputObject -Right ([pscustomobject]$ChgProperties) -Join FULL -WarningAction SilentlyContinue
-        if ($NewObject -ne $null -and $pscmdlet.ShouldProcess($F5Session.Name, "Setting Pool $Name")) {
+        if ($null -ne $NewObject -and $pscmdlet.ShouldProcess($F5Session.Name, "Setting Pool $Name")) {
 
             # We only update the pool if properties other than 'Name' are passed in
-            If ($NewObject | Get-Member -MemberType NoteProperty | Where Name -ne 'Name'){
+            If ($NewObject | Get-Member -MemberType NoteProperty | Where-Object Name -ne 'Name'){
 
                 Write-Verbose -Message 'Setting Pool details...'
 
@@ -144,7 +144,7 @@
 
                 #endregion
 
-                $result = Invoke-F5RestMethod -Method PATCH -URI "$URI" -F5Session $F5Session -Body $JSONBody -ContentType 'application/json'
+                $null = Invoke-F5RestMethod -Method PATCH -URI "$URI" -F5Session $F5Session -Body $JSONBody -ContentType 'application/json'
 
             }
 

F5-LTM/Public/Set-VirtualServer.ps1

@@ -219,15 +219,15 @@ Function Set-VirtualServer {
         if (-not $NewProperties.ContainsKey('DestinationIP')) {
             $destination = if ($InputObject -and $InputObject.destination) {
                 $InputObject.destination
-            } elseif ($ExistingVirtualServer -ne $null) {
+            } elseif ($null -ne $ExistingVirtualServer) {
                 $ExistingVirtualServer.destination
             }
             if ($destination) { $NewProperties['DestinationIP'] = ($destination -split ':')[0] }
         }
         if (-not $NewProperties.ContainsKey('DestinationPort')) {
             $destination = if ($InputObject -and $InputObject.destination) {
                 $InputObject.destination
-            } elseif ($ExistingVirtualServer -ne $null) {
+            } elseif ($null -eq $ExistingVirtualServer) {
                 $ExistingVirtualServer.destination
             }
             if ($destination) { $NewProperties['DestinationPort'] = ($destination -split ':')[1] }
@@ -243,7 +243,7 @@ Function Set-VirtualServer {
         }
         # This performs the magic necessary for ChgProperties to override $InputObject properties
         $NewObject = Join-Object -Left $InputObject -Right ([pscustomobject]$ChgProperties) -Join FULL -WarningAction SilentlyContinue
-        if ($NewObject -ne $null -and $pscmdlet.ShouldProcess($F5Session.Name, "Setting VirtualServer $Name")) {
+        if ($null -ne $NewObject -and $pscmdlet.ShouldProcess($F5Session.Name, "Setting VirtualServer $Name")) {
             Write-Verbose -Message 'Setting VirtualServer details...'
 
             $URI = $F5Session.BaseURL + 'virtual/{0}' -f (Get-ItemPath -Name $Name -Application $Application -Partition $Partition)
@@ -259,7 +259,7 @@ Function Set-VirtualServer {
 
             #endregion
 
-            $result = Invoke-F5RestMethod -Method PATCH -URI "$URI" -F5Session $F5Session -Body $JSONBody -ContentType 'application/json'
+            $null = Invoke-F5RestMethod -Method PATCH -URI "$URI" -F5Session $F5Session -Body $JSONBody -ContentType 'application/json'
         }
         if ($PassThru) { Get-VirtualServer -F5Session $F5Session -Name $Name -Application $Application -Partition $Partition }
     }

appveyor.yml

@@ -18,7 +18,7 @@ install:
   # Force bootstrap of the Nuget PackageManagement Provider; Reference: http://www.powershellgallery.com/GettingStarted?section=Get%20Started
   - ps: Get-PackageProvider -Name NuGet -Force
   # Install pester PowerShell Unit Testing module
-  #- cinst -y pester
+  - cinst -y pester
 
 before_test:
   # Set FunctionsToExport and ModuleVersion in the module manifest (F5-LTM.psd1); Fixes #37 Do not export Private\*.ps1 functions
@@ -35,20 +35,14 @@ test_script:
   # Invoke PSScriptAnalyzer against the module to make sure it's not failing any tests
   - ps: Invoke-ScriptAnalyzer -Path (Join-Path $env:APPVEYOR_BUILD_FOLDER 'F5-LTM') -Recurse
   # Invoke-Pester unit tests
-  #- ps: |
-  #  $testResultsFile = '.\TestsResults.xml'
-  #
-  #  # run tests
-  #     $res = Invoke-Pester -OutputFormat NUnitXml -OutputFile $testResultsFile -PassThru
-  #
-  #  # upload results to AppVeyor
-  #  (New-Object 'System.Net.WebClient').UploadFile("https://ci.appveyor.com/api/testresults/nunit/$($env:APPVEYOR_JOB_ID)", (Resolve-Path $testResultsFile))
-  #
-  #  # if failures, quit to prevent publish
-  #  if ($res.FailedCount -gt 0) { 
-  #    throw "$($res.FailedCount) tests failed."
-  #  }
-
+  - ps: $testResultsFile = '.\TestsResults.xml'
+    # run tests
+  - ps: $res = Invoke-Pester -OutputFormat NUnitXml -OutputFile $testResultsFile -PassThru
+    # upload results to AppVeyor
+  - ps: (New-Object 'System.Net.WebClient').UploadFile("https://ci.appveyor.com/api/testresults/nunit/$($env:APPVEYOR_JOB_ID)", (Resolve-Path $testResultsFile))
+    # if failures, quit to prevent publish
+  - ps: if ($res.FailedCount -gt 0) { "$($res.FailedCount) tests failed." }
+
 deploy_script:
   # Publish module to the PowerShellGallery
   - ps: Publish-Module -NugetApiKey $env:POWERSHELLGALLERY_APIKEY -Path (Join-Path $env:APPVEYOR_BUILD_FOLDER 'F5-LTM')