Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize PJRT plugins #444

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+31 −1
Open

initialize PJRT plugins #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebdc458
initialize PJRT plugins
joelberkeley Jan 11, 2025
cb6d541
wip
joelberkeley Jan 11, 2025
cdeac71
wip
joelberkeley Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pjrt-plugins/xla-cpu/PjrtPluginXlaCpu.idr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,5 @@ export
device : Pjrt Device
device = do
api <- MkPjrtApi <$> primIO prim__getPjrtApi
pjrtPluginInitialize api
MkDevice api <$> pjrtClientCreate api
1 change: 1 addition & 0 deletions pjrt-plugins/xla-cuda/PjrtPluginXlaCuda.idr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,5 @@ export
device : Pjrt Device
device = do
api <- MkPjrtApi <$> primIO prim__getPjrtApi
pjrtPluginInitialize api
MkDevice api <$> pjrtClientCreate api
2 changes: 1 addition & 1 deletion spidr/backend/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.0.14
0.0.15
11 changes: 11 additions & 0 deletions spidr/backend/src/xla/pjrt/c/pjrt_c_api.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,17 @@ extern "C" {
return api->PJRT_Error_GetCode(args);
}

PJRT_Plugin_Initialize_Args* PJRT_Plugin_Initialize_Args_new() {
return new PJRT_Plugin_Initialize_Args{
.struct_size = PJRT_Plugin_Initialize_Args_STRUCT_SIZE,
.extension_start = nullptr,
};
}

PJRT_Error* pjrt_plugin_initialize(PJRT_Api* api, PJRT_Plugin_Initialize_Args* args) {
return api->PJRT_Plugin_Initialize(args);
}

PJRT_Event_Destroy_Args* PJRT_Event_Destroy_Args_new(PJRT_Event* event) {
return new PJRT_Event_Destroy_Args{
.struct_size = PJRT_Event_Destroy_Args_STRUCT_SIZE,
Expand Down
17 changes: 17 additions & 0 deletions spidr/src/Compiler/Xla/PJRT/C/PjrtCApi.idr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,23 @@ try api err onOk = if (isNullPtr err) then right onOk else do
destroyPjrtError api err
left $ MkPjrtError msg $ map pjrtErrorCodeFromCInt code

%foreign (libxla "PJRT_Plugin_Initialize_Args_new")
prim__mkPjrtPluginInitializeArgs : PrimIO AnyPtr

%foreign (libxla "pjrt_plugin_initialize")
prim__pjrtPluginInitialize : AnyPtr -> AnyPtr -> PrimIO AnyPtr

||| For use by plugin developers.
|||
||| One-time plugin setup. Must be called before any other functions are called.
export
pjrtPluginInitialize : PjrtApi -> Pjrt ()
pjrtPluginInitialize (MkPjrtApi api) = do
args <- primIO prim__mkPjrtPluginInitializeArgs
err <- primIO $ prim__pjrtPluginInitialize api args
free args
try api err ()

||| For internal spidr use only.
export
data PjrtEvent = MkPjrtEvent AnyPtr
Expand Down
Loading