-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format files and fix issues found by quality check #211
Conversation
Replace single quotes with ""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there may be other potential style issues, have you checked the rest of the file?
@MKhalusova I would not be surprised about that. How do I check locally? I have used npm to run tests on json files, but I am not sure how to check the mdx files. Is there a reference I could look at? |
Run |
Thanks! I was trying to pass the computer-vision-course folder as an argument. |
@MKhalusova I have added the fixes for the first two mdx files that were failed the checks. Feature-matchng.mdx is still failing with the change to "". |
@MKhalusova Yea, It passed the quality checks! |
Hooray! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @kfahn22 ! 🤗
just one thing here I think |
If you're referring to the build_pr_documentation job, I don't think it's working yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Only change is replacing single quotes with ""