-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added video classification using ViViT model (Unit-7 notebook) #327
Added video classification using ViViT model (Unit-7 notebook) #327
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hey @DiwakarBasnet, thanks for contributing this notebook. I just ran the code in colab and it all worked, which is amazing 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DiwakarBasnet 😄!
I'll conduct an in-depth review but you can already review the general text since there are some small issues like:
architecuter
in the second paragraph
Hey @johko @sergiopaniego , thanks so much for your feedback! I'm glad to hear that the code worked well for you in Colab, that's awesome to know! 😄 |
View / edit / reply to this conversation on ReviewNB sergiopaniego commented on 2024-08-21T17:25:41Z Typo in |
View / edit / reply to this conversation on ReviewNB sergiopaniego commented on 2024-08-21T17:25:41Z I would suggest removing code output through the notebook for cleanliness if not relevant for the explanation. |
View / edit / reply to this conversation on ReviewNB sergiopaniego commented on 2024-08-21T17:25:42Z finetuning -> fine tuning colab -> Colab coprises -> comprises Vivit -> ViViT |
View / edit / reply to this conversation on ReviewNB sergiopaniego commented on 2024-08-21T17:25:43Z I'd suggest adding links to |
View / edit / reply to this conversation on ReviewNB sergiopaniego commented on 2024-08-21T17:25:44Z input to the transformer encoder is; -> input to the transformer encoder is as follows; -> as follows |
View / edit / reply to this conversation on ReviewNB sergiopaniego commented on 2024-08-21T17:25:44Z The numeration need some modifications to properly show the inderx. ANd
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some comments on the notebook 😄
I have updated the notebook with the comments you have made @sergiopaniego 😊. If there is a better way to show the videos in the notebook do let me know 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We may need to add the notebook to the table of contents 😄. https://huggingface.co/learn/computer-vision-course/unit0/welcome/TableOfContents
View / edit / reply to this conversation on ReviewNB johko commented on 2024-10-23T18:08:29Z Line #2. !pip install pytorchvideo evaluate accelerate transformers > /dev/null 2>&1 instead of piping the output you could do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry for the very very late reply and review. I had a rather quick run-through of the notebook just now and everything looks okay from my side
@sergiopaniego as you reviewed this quite a bit - do you think this is approval worthy from your side? |
Changes approved! |
I agree with @sergiopaniego, when you added the notebook to the overview, we can merge this @DiwakarBasnet |
Sorry couldn't see the comments, I have linked the notebook to Table of contents |
Added colab notebook for implementation of fine-tuning ViViT model for video classification task.