Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added video classification using ViViT model (Unit-7 notebook) #327

Merged
merged 10 commits into from
Oct 27, 2024

Conversation

DiwakarBasnet
Copy link
Contributor

Added colab notebook for implementation of fine-tuning ViViT model for video classification task.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@johko
Copy link
Owner

johko commented Aug 20, 2024

Hey @DiwakarBasnet, thanks for contributing this notebook. I just ran the code in colab and it all worked, which is amazing 😉
I'll go through the text in the next days, because I think there are a few grammatical things that can be improved, but great work already 👍

Copy link
Collaborator

@sergiopaniego sergiopaniego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DiwakarBasnet 😄!
I'll conduct an in-depth review but you can already review the general text since there are some small issues like:

  • architecuter in the second paragraph

@DiwakarBasnet
Copy link
Contributor Author

DiwakarBasnet commented Aug 20, 2024

Hey @johko @sergiopaniego , thanks so much for your feedback! I'm glad to hear that the code worked well for you in Colab, that's awesome to know! 😄
The notebook was actually done quite a while ago, so it could definitely use some updates. I had intended to make the PR sooner, but I got caught up with other tasks. I’m glad to finally get this out there, and I’m looking forward to your suggestions on how we can improve it. Thanks again for your help! 👍

Copy link

review-notebook-app bot commented Aug 21, 2024

View / edit / reply to this conversation on ReviewNB

sergiopaniego commented on 2024-08-21T17:25:41Z
----------------------------------------------------------------

Typo in architecuter.


Copy link

review-notebook-app bot commented Aug 21, 2024

View / edit / reply to this conversation on ReviewNB

sergiopaniego commented on 2024-08-21T17:25:41Z
----------------------------------------------------------------

I would suggest removing code output through the notebook for cleanliness if not relevant for the explanation.


Copy link

review-notebook-app bot commented Aug 21, 2024

View / edit / reply to this conversation on ReviewNB

sergiopaniego commented on 2024-08-21T17:25:42Z
----------------------------------------------------------------

finetuning -> fine tuning

colab -> Colab

coprises -> comprises

Vivit -> ViViT


Copy link

review-notebook-app bot commented Aug 21, 2024

View / edit / reply to this conversation on ReviewNB

sergiopaniego commented on 2024-08-21T17:25:43Z
----------------------------------------------------------------

I'd suggest adding links to huggingface dataset and sayakpaul's profile.


Copy link

review-notebook-app bot commented Aug 21, 2024

View / edit / reply to this conversation on ReviewNB

sergiopaniego commented on 2024-08-21T17:25:44Z
----------------------------------------------------------------

input to the transformer encoder is; -> input to the transformer encoder is:

as follows; -> as follows:


Copy link

review-notebook-app bot commented Aug 21, 2024

View / edit / reply to this conversation on ReviewNB

sergiopaniego commented on 2024-08-21T17:25:44Z
----------------------------------------------------------------

The numeration need some modifications to properly show the 4 variants.

inderx.

ANd


Copy link
Collaborator

@sergiopaniego sergiopaniego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some comments on the notebook 😄

@DiwakarBasnet
Copy link
Contributor Author

I have updated the notebook with the comments you have made @sergiopaniego 😊. If there is a better way to show the videos in the notebook do let me know 🤗

Copy link
Collaborator

@sergiopaniego sergiopaniego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We may need to add the notebook to the table of contents 😄. https://huggingface.co/learn/computer-vision-course/unit0/welcome/TableOfContents

Copy link

review-notebook-app bot commented Oct 23, 2024

View / edit / reply to this conversation on ReviewNB

johko commented on 2024-10-23T18:08:29Z
----------------------------------------------------------------

Line #2.    !pip install pytorchvideo evaluate accelerate transformers > /dev/null 2>&1

instead of piping the output you could do !pip -q install


Copy link
Owner

@johko johko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for the very very late reply and review. I had a rather quick run-through of the notebook just now and everything looks okay from my side

@johko
Copy link
Owner

johko commented Oct 23, 2024

@sergiopaniego as you reviewed this quite a bit - do you think this is approval worthy from your side?

@sergiopaniego
Copy link
Collaborator

Changes approved!
I think this notebook should be linked to the table of contents here so it's visible.
cc @DiwakarBasnet

@johko
Copy link
Owner

johko commented Oct 26, 2024

I agree with @sergiopaniego, when you added the notebook to the overview, we can merge this @DiwakarBasnet

@DiwakarBasnet
Copy link
Contributor Author

Sorry couldn't see the comments, I have linked the notebook to Table of contents

@johko johko merged commit f95f961 into johko:stage Oct 27, 2024
2 checks passed
@DiwakarBasnet DiwakarBasnet deleted the unit-7_Video_and_VideoProcessing branch October 28, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants