Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added video processing section (Unit 7 - RNN Based Video Model) #354

Merged
merged 15 commits into from
Nov 14, 2024
Merged

Added video processing section (Unit 7 - RNN Based Video Model) #354

merged 15 commits into from
Nov 14, 2024

Conversation

jungnerd
Copy link
Contributor

@jungnerd jungnerd commented Oct 5, 2024 •
edited
Loading

What does this PR do?

We aim to explain deep learning architectures for processing videos in Unit 7 Video & Video Processing.
Specifically, this document focuses on explaining RNN-based video models.

Thank you in advance for your review.

Part of #348

Who can review?

@mreraser @cjfghk5697 @1kmmk1 and anyone who wants to review!

@mreraser
Copy link
Contributor

mreraser commented Oct 5, 2024

LGTM 👍

jungnerd
jungnerd commented Oct 8, 2024
View reviewed changes
chapters/en/_toctree.yml Outdated Show resolved Hide resolved
jungnerd
jungnerd commented Oct 8, 2024
View reviewed changes
Copy link
Contributor Author

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add image files

chapters/en/unit7/video-processing/rnn-based-video-models.mdx Outdated Show resolved Hide resolved
chapters/en/unit7/video-processing/rnn-based-video-models.mdx Outdated Show resolved Hide resolved
chapters/en/unit7/video-processing/rnn-based-video-models.mdx Outdated Show resolved Hide resolved
chapters/en/unit7/video-processing/rnn-based-video-models.mdx Outdated Show resolved Hide resolved
@jungnerd
Copy link
Contributor Author

Hi, @johko 👋🏻
Would you mind reviewing this PR?

johko
johko reviewed Oct 23, 2024
View reviewed changes
Copy link
Owner

@johko johko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice contribution!
I just have some small nits and overall it might be nice to have some references to use cases of the models (as mentioned in one of the comments)

chapters/en/unit7/video-processing/rnn-based-video-models.mdx Outdated Show resolved Hide resolved
chapters/en/unit7/video-processing/rnn-based-video-models.mdx Outdated Show resolved Hide resolved
chapters/en/unit7/video-processing/rnn-based-video-models.mdx Show resolved Hide resolved
jungnerd
jungnerd commented Nov 5, 2024
View reviewed changes
Copy link
Contributor Author

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove anchors

chapters/en/unit7/video-processing/rnn-based-video-models.mdx Outdated Show resolved Hide resolved
chapters/en/unit7/video-processing/rnn-based-video-models.mdx Outdated Show resolved Hide resolved
chapters/en/unit7/video-processing/rnn-based-video-models.mdx Outdated Show resolved Hide resolved
chapters/en/unit7/video-processing/rnn-based-video-models.mdx Outdated Show resolved Hide resolved
chapters/en/unit7/video-processing/rnn-based-video-models.mdx Outdated Show resolved Hide resolved
chapters/en/unit7/video-processing/rnn-based-video-models.mdx Outdated Show resolved Hide resolved
chapters/en/unit7/video-processing/rnn-based-video-models.mdx Outdated Show resolved Hide resolved
chapters/en/unit7/video-processing/rnn-based-video-models.mdx Outdated Show resolved Hide resolved
chapters/en/unit7/video-processing/rnn-based-video-models.mdx Outdated Show resolved Hide resolved
chapters/en/unit7/video-processing/rnn-based-video-models.mdx Show resolved Hide resolved
johko
johko approved these changes Nov 13, 2024
View reviewed changes
Copy link
Owner

@johko johko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ATaylorAerospace ATaylorAerospace self-requested a review November 14, 2024 10:53
ATaylorAerospace
ATaylorAerospace approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@ATaylorAerospace ATaylorAerospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great updates for Unit 7. LGTM!

@ATaylorAerospace ATaylorAerospace merged commit ef76dfb into johko:stage Nov 14, 2024
2 checks passed
@jungnerd jungnerd deleted the unit7-rnn branch November 14, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mreraser mreraser mreraser left review comments

@ATaylorAerospace ATaylorAerospace ATaylorAerospace approved these changes

@johko johko johko approved these changes

@merveenoyan merveenoyan Awaiting requested review from merveenoyan merveenoyan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jungnerd @mreraser @johko @ATaylorAerospace