Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor accessibility issue #120

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Minor accessibility issue #120

wants to merge 4 commits into from

Conversation

davidmcdermott2
Copy link

Steps to produce issue

  1. Ensure your Android device supports Talkback (screen reader) and turn it on
  2. Ensure the CountryCodePicker has a country preference set
  3. Open the CountryCodePicker dialog and scroll through the list of countries
  4. The horizontal divider line will be read as "unlabeled" by Talkback without these changes which would be confusing to users
  5. With this PR the divider will be read as "country preference divider" instead

It's possible to set the divider as skippable by Talkback but this requires bumping min sdk from 14 to 16

@davidmcdermott2
first commit. make divider not important for accessibility
13ea860
@davidmcdermott2
undo changes to group, version, etc.
2206d53
@davidmcdermott2
restore min sdk version to 14. important for accessibility requires m…
95cde86 
…in sdk of 16 but setting the content description instead is ok on 14. Talkback should now announce the divider as "country preference divier" instead of just saying "unlabeled"
darcishED
darcishED reviewed Aug 3, 2022
View reviewed changes
Copy link

@darcishED darcishED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are making the default preferences to US?.. can't the user of the library choose the preference he/she wants?

otherwise, everything else LGTM.

@davidmcdermott2
Copy link
Author

Hello I have removed the default US preference. No reason for it. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcishED darcishED darcishED approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidmcdermott2 @darcishED