[5.3] Global Configuration: Link SEO to SEF plugin #44749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pe7er
changed the title
joomla-cms-bot
added
the
NPM Resource Changed
|
81 changed files? |
I think that comes from rebasing this PR from 5.2-dev to 5.3-dev and should be fixed after the next upmerge from 5.2-dev to 5.3-dev and then update this PR to the updated base branch. |
|
I have tested this item ✅ successfully on 639231a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44749. |
1 similar comment
|
I have tested this item ✅ successfully on 639231a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44749. |
|
This is not correct In all the other examples I could find for this the URL is not part of the language string and the link is opened in a modal. Doing it the way it is here you will navigate to a new page without saving the changes you have already made. See the following examples |
|
I have tested this item 🔴 unsuccessfully on 639231a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44749. |
sandewt
reviewed
Jan 21, 2025
| @@ -85,6 +85,10 @@ public static function getDebugActions($component = null) | |||
| $component_actions = Access::getActionsFromFile(JPATH_ADMINISTRATOR . '/components/' . $component . '/access.xml'); | |||
|
|
|||
| if (!empty($component_actions)) { | |||
| // Load language | |||
| $lang = Factory::getApplication()->getLanguage(); | |||
There was a problem hiding this comment.
Suggested change
| $lang = Factory::getApplication()->getLanguage(); | |
| $lang = Factory::getApplication()->getLanguage(); |
joomla-cms-bot
removed
the
NPM Resource Changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a link to the Global Configuration > SEO >
Additional settings can be found in the "System - SEF" plugin.Summary of Changes
Testing Instructions
/administrator/index.php?option=com_config, "Site" tab > SEO sectionActual result BEFORE applying this Pull Request
The notice
Additional settings can be found in the "System - SEF" plugin.is just a notice.Expected result AFTER applying this Pull Request
The notice
Additional settings can be found in the "System - SEF" plugin.has a link to go to the Plugins to easily find the"System - SEF"PluginAfter clicking on "System - SEF", the Plugins are filtered on Type=system, Element=sef:
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed