Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Convert mod_privacy_status to service provider #44752

Open
wants to merge 11 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

joomlaweby
Copy link
Contributor

Summary of Changes

Converts the privacy status module to service provider.

Testing Instructions

  1. Make sure you have administrator module mod_privacy_status published
  2. You should see module output

mod_privacy_status

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Jan 19, 2025

I have tested this item ✅ successfully on bde9420

Module looks before and after Pull Request same.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44752.

Copy link
Contributor

@joomdonation joomdonation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some suggestions for better method names (I hope) and it should be ready for testing. Thanks !

Copy link
Contributor

@joomdonation joomdonation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, still more changes are needed. Please look at it and implement the change when you have time. Thanks !

@joomdonation
Copy link
Contributor

Thanks @joomlaweby. It is all good now. @fgsw Could you please test it again? Thanks.

@joomlaweby
Copy link
Contributor Author

@joomdonation great! Thanks for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants