-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Convert mod_privacy_status to service provider #44752
base: 5.3-dev
Are you sure you want to change the base?
Conversation
administrator/modules/mod_privacy_status/src/Helper/PrivacyStatusHelper.php
Outdated
Show resolved
Hide resolved
administrator/modules/mod_privacy_status/src/Dispatcher/Dispatcher.php
Outdated
Show resolved
Hide resolved
I have tested this item ✅ successfully on bde9420 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44752. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some suggestions for better method names (I hope) and it should be ready for testing. Thanks !
administrator/modules/mod_privacy_status/src/Helper/PrivacyStatusHelper.php
Outdated
Show resolved
Hide resolved
administrator/modules/mod_privacy_status/src/Helper/PrivacyStatusHelper.php
Outdated
Show resolved
Hide resolved
administrator/modules/mod_privacy_status/src/Helper/PrivacyStatusHelper.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, still more changes are needed. Please look at it and implement the change when you have time. Thanks !
administrator/modules/mod_privacy_status/src/Helper/PrivacyStatusHelper.php
Outdated
Show resolved
Hide resolved
administrator/modules/mod_privacy_status/src/Helper/PrivacyStatusHelper.php
Outdated
Show resolved
Hide resolved
administrator/modules/mod_privacy_status/src/Helper/PrivacyStatusHelper.php
Outdated
Show resolved
Hide resolved
administrator/modules/mod_privacy_status/src/Helper/PrivacyStatusHelper.php
Outdated
Show resolved
Hide resolved
Thanks @joomlaweby. It is all good now. @fgsw Could you please test it again? Thanks. |
@joomdonation great! Thanks for review! |
Summary of Changes
Converts the privacy status module to service provider.
Testing Instructions
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed