[5.3] Improve error handling for creating autload_psr4.php #44763
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR stems from an update issue. After updating, the /administrator/cache/autoload_psr4.php is deleted and should be regenerated automatically. However the webspace was full and thus the file couldn't be written. In theory we have a fallback for this, however that fallback expects an exception to be thrown, which the code actually doesn't do. This PR adds an additional check for this.
Unfortunately I couldn't replicate the issue itself, since I can't make the folder write-protected on my windows machine and I don't have a Linux machine available right now to test this. So this change was done by me on codereview alone.
Testing Instructions
Actual result BEFORE applying this Pull Request
The site displays a 500 error about being unable to include the autoload_psr4.php and the file is not created.
Expected result AFTER applying this Pull Request
The site works like before, even though it might be a bit slower. The autoload_psr4.php is not created.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed