Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validation status for disabled dropdown #4552

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

tayyabataimur
Copy link
Contributor

Fixes #4548

Screenshots

Before
image


After
image

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 1:32pm

Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 7845c7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@salt-ds/core Patch
@salt-ds/countries Patch
@salt-ds/data-grid Patch
@salt-ds/lab Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tayyabataimur tayyabataimur force-pushed the dropdown-disabled-validation branch from 948a7d0 to 5e9c8e4 Compare January 9, 2025 09:57
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 9, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 9, 2025
@tayyabataimur tayyabataimur force-pushed the dropdown-disabled-validation branch from 5e9c8e4 to 78f9fbc Compare January 9, 2025 11:24
@tayyabataimur tayyabataimur added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 9, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 9, 2025
@tayyabataimur tayyabataimur force-pushed the dropdown-disabled-validation branch from 78f9fbc to fd83e62 Compare January 9, 2025 17:36
@tayyabataimur tayyabataimur added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 9, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 9, 2025
@tayyabataimur tayyabataimur force-pushed the dropdown-disabled-validation branch from fd83e62 to 88f5cbf Compare January 10, 2025 08:15
@tayyabataimur tayyabataimur added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 10, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 10, 2025
@tayyabataimur tayyabataimur added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 10, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 10, 2025
@tayyabataimur tayyabataimur force-pushed the dropdown-disabled-validation branch from 341bae0 to 7845c7a Compare January 10, 2025 13:14
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 10, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 10, 2025
@tayyabataimur tayyabataimur merged commit cd98ba5 into main Jan 10, 2025
15 checks passed
@tayyabataimur tayyabataimur deleted the dropdown-disabled-validation branch January 10, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation status shouldn't be applied when Dropdown is disabled
3 participants