Use aspect hint for CYaml in Bazel #423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rules_swift 2.0 requires using the `aspect_hints` attribute to specify interop between `cc_library` and `swift_library`. This change adds the `aspect_hints` attribute to the `cc_library` rule for CYaml. It increases the minimum supported rules_swift version to 2.0
brentleyjones
approved these changes
Jul 10, 2024
| @@ -5,7 +5,7 @@ module( | |||
| ) | |||
|
|
|||
| bazel_dep(name = "apple_support", version = "1.15.1") | |||
| bazel_dep(name = "rules_swift", version = "1.18.0", repo_name = "build_bazel_rules_swift", max_compatibility_level = 2) | |||
| bazel_dep(name = "rules_swift", version = "2.0.0", repo_name = "build_bazel_rules_swift") | |||
There was a problem hiding this comment.
We should wait until 2.1.1 is approved, and use that, since it has a big bug fix in it.
|
Because this has a custom module map which is found via includes, we don't actually need to use aspect hints / increase rules_swift version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_swift 2.0 requires using the
aspect_hintsattribute to specify interop betweencc_libraryandswift_library. This change adds theaspect_hintsattribute to thecc_libraryrule for CYaml. It increases the minimum supported rules_swift version to 2.0