Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a new event id accessor that is used as a react key, falls back to default #2693

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

milkman4
Copy link
Contributor

@milkman4 milkman4 commented Dec 11, 2024

#2694

This PR adds a new accessor for eventId that is applied to the timeGridEvent key, when rendered in the dayColumn. This will allow unique identification of events for proper behavior.

@milkman4 milkman4 changed the title adds a new event id accessor that is used as a react key, falls bak to default adds a new event id accessor that is used as a react key, falls back to default Dec 11, 2024
@milkman4 milkman4 marked this pull request as ready for review December 11, 2024 14:58
Copy link
Collaborator

@cutterbl cutterbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few bits for you to look at, but otherwise looks good.

src/DayColumn.js Outdated Show resolved Hide resolved
stories/props/eventIdAccessor.mdx Outdated Show resolved Hide resolved
@milkman4 milkman4 requested a review from cutterbl December 11, 2024 15:27
Copy link
Collaborator

@cutterbl cutterbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last bit that I missed before.

src/Calendar.js Show resolved Hide resolved
@milkman4 milkman4 requested a review from cutterbl December 11, 2024 15:59
@cutterbl cutterbl merged commit 9883ace into jquense:master Dec 11, 2024
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
# [1.17.0](v1.16.3...v1.17.0) (2024-12-11)

### Features

* adds a new event id accessor ([#2693](#2693)) ([9883ace](9883ace))
Copy link

🎉 This PR is included in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@milkman4 milkman4 deleted the mk-add-event-id-accessor branch December 11, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants