fix: white background for lightmode #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the light mode background to #FFFFFF.
The motivation is that we need to support HTML and PDF, and PDF is probably the more important of the two. Unfortunately, the PDF looks ugly with a non-white background as the background only extends to the content/body, not the remainder of the last page.
Ideally, I should've been able to use a media query like:
However, it seems the renderer doesn't use print media queries, so this was ignored. When or if this is supported, it'd be much better to change the background color back to
#F9F9F9
and put the media query back.Related