Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: white background for lightmode #38

Merged
merged 1 commit into from
May 21, 2023

Conversation

SethFalco
Copy link
Member

@SethFalco SethFalco commented May 21, 2023

Changes the light mode background to #FFFFFF.

The motivation is that we need to support HTML and PDF, and PDF is probably the more important of the two. Unfortunately, the PDF looks ugly with a non-white background as the background only extends to the content/body, not the remainder of the last page.

Ideally, I should've been able to use a media query like:

@media (print) {
  body {
    --bg-color: #FFFFFF;
  }
}

However, it seems the renderer doesn't use print media queries, so this was ignored. When or if this is supported, it'd be much better to change the background color back to #F9F9F9 and put the media query back.

Related

@SethFalco SethFalco merged commit 62f0a71 into jsonresume:main May 21, 2023
@SethFalco SethFalco deleted the pdf-background branch January 12, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant