disable C4710

jupyter-xeus · Jan 26, 2025 · c365c36 · c365c36
1 parent 21c362a
commit c365c36
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 20 deletions.
diff --git a/cmake/Warnings.cmake b/cmake/Warnings.cmake
@@ -64,9 +64,11 @@ set(MSVC_WARNINGS
         "/W4"
         "/Wall"
         "/WL"
-        "/wd5045"
-        "/wd4820"
-        "/wd4514")
+        "/wd5045" #FIXME
+        "/wd4820" #FIXME
+        "/wd4514" #FIXME
+        "/wd4710" #FIXME
+        )
 
 target_compile_options(
   ${PROJECT_NAME}Warnings

diff --git a/cpp-terminal/buffer.hpp b/cpp-terminal/buffer.hpp
@@ -11,15 +11,7 @@
 
 #include <cstddef>
 #include <cstdint>
-
-#ifdef _WIN32
-  #pragma warning( push )
-  #pragma warning( disable : 4710)
-#endif
 #include <streambuf>
-#ifdef _WIN32
-  #pragma warning( pop )
-#endif
 
 namespace Term
 {

diff --git a/cpp-terminal/iostream_initializer.cpp b/cpp-terminal/iostream_initializer.cpp
@@ -16,15 +16,7 @@
 #include "cpp-terminal/tty.hpp"
 
 #include <cstddef>
-
-#ifdef _WIN32
-  #pragma warning( push )
-  #pragma warning( disable : 4710)
-#endif
 #include <iostream>
-#ifdef _WIN32
-  #pragma warning( pop )
-#endif
 
 std::size_t Term::IOStreamInitializer::m_counter{0};
 

diff --git a/cpp-terminal/private/terminal_impl.cpp b/cpp-terminal/private/terminal_impl.cpp
@@ -18,7 +18,6 @@
   #include <io.h>
   #pragma warning(push)
   #pragma warning(disable : 4668)
-  #pragma warning(disable : 4710)
   #include <windows.h>
   #pragma warning(pop)
   #if !defined(ENABLE_VIRTUAL_TERMINAL_PROCESSING)