feat: virtualenv improvements #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think more or less the same as https://github.com/justjanne/powerline-go/pull/387/files right? |
|
That one does not look at |
|
...except that I won't :) The implementation here falls back to the venv dir even if loading the pyvenv.cfg fails for some reason. For example, does it exist in all venv dirs, e.g. ones created by old versions of |
|
When I get a chance I'll compare our changes, we can probably just merge them into one PR since they're both related. 👍 |
|
any chance of getting this merged? |
Standard venv activation typically sets it to `(name) `. Parse that first to avoid having to parse pyvenv.cfg. Co-authored-by: Janne Mareike Koschinski <[email protected]>
scop
force-pushed
the
feat/virtualenv-improvements
branch
from
3241c1b to
ef5e672
Compare
justjanne
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some virtualenv improvements, see individual commits for details.