New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFRACTOR] Hooks recieve a single parameter #639

Draft

TungstnBallon wants to merge 2 commits into main from hooks-3

Contributor

TungstnBallon commented Jan 21, 2025

This PR changes the hook's signature to only receive one object with the previous parameter as properties. This has the following advantages:

Backwards compatibility: Adding new "parameters" at whatever position doesn't break existing code
It's easier to ignore unused "parameters".

Depends on #638, which is why I've marked this as a draft.

TungstnBallon added 2 commits

January 15, 2025 17:03


          Include hooks in block duration logging

df34ae9


          refractor: Hooks recieve one single parameter with properties

44b3c32

TungstnBallon self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet