Remove cv.sfm dependency #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Philip, Thanks for the PR! This could be very helpful. Unfortunately I don't have the time/ability to properly test this right now, so I'll pull it into a new branch and update the readme to let people know that the no opencv-sfm code is experimentally available. The best way to probably test this would be to generate random data and compare the opencv-sfm results to your code, which unfortunately would also require setting up some testing infrastructure which doesn't currently exist in the codebase. |
|
Great that sounds good to me! If I end up figuring out the testing I’ll make another PR into that branch. |
|
The configuration of the SFM module is quite complicated. May I ask if your NoSFM module has been set up and tested for use? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4.
I decided to take this on to better understand the math going on in the backend here. I haven't built the sfm version of opencv myself, and don't have the pseye cameras or drones to test my replacement of it myself, so thorough real use testing should be done before merging this.
I did look at the opencv_sfm test suite, but they only test by making raw data, doing one set of conversions, converting back, and testing that the results match. Since I didn't implement the reverse of these functions I didn't implement that, and it did not give me examples to test these functions with.
The file that contained the functions I adapted from included a BSD license that I have included here out of caution.