Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON Schema #650

Merged
merged 6 commits into from
Jan 26, 2025
Merged

Fix JSON Schema #650

merged 6 commits into from
Jan 26, 2025

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Jan 26, 2025

ref: #646

SSIA.

@k1LoW k1LoW self-assigned this Jan 26, 2025
@k1LoW k1LoW added the bug Something isn't working label Jan 26, 2025

This comment has been minimized.

Copy link
Contributor

Code Metrics Report

main (f542f95) #650 (30c4592) +/-
Coverage 55.6% 54.1% -1.6%
Code to Test Ratio 1:0.4 1:0.4 -0.1
Test Execution Time 4m25s 4m26s +1s
Details
  |                     | main (f542f95) | #650 (30c4592) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          55.6% |          54.1% | -1.6% |
  |   Files             |             52 |             52 |     0 |
  |   Lines             |           4798 |           4807 |    +9 |
- |   Covered           |           2671 |           2602 |   -69 |
- | Code to Test Ratio  |          1:0.4 |          1:0.4 |  -0.1 |
  |   Code              |          10390 |          10422 |   +32 |
  |   Test              |           4342 |           4342 |     0 |
- | Test Execution Time |          4m25s |          4m26s |   +1s |

Code coverage of files in pull request scope (51.5% → 51.9%)

Files Coverage +/-
schema/json.go 83.6% -1.8%
schema/schema.go 39.8% 0.0%

Reported by octocov

@k1LoW k1LoW merged commit 75fefd8 into main Jan 26, 2025
4 checks passed
@k1LoW k1LoW deleted the fix-jsonschema branch January 26, 2025 13:11
@github-actions github-actions bot mentioned this pull request Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant