fix: Replace j2cli with jinjanator in GitHub workflows #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshoval
reviewed
Oct 31, 2023
| @@ -15,7 +15,8 @@ jobs: | |||
| python-version: 3.x | |||
|
|
|||
| - run: | | |||
| pip3 install --user --upgrade j2cli | |||
| pip3 install --user --upgrade jinjanator | |||
| ln -s ~/.local/bin/jinjanate ~/.local/bin/j2 | |||
There was a problem hiding this comment.
nice, why soft link and not replace line on j2 ?
There was a problem hiding this comment.
I didn't want to break local workflows for now. There also an issue on jinjanator to make it a drop-in replacement: kpfleming/jinjanator#25
There was a problem hiding this comment.
can you pin some python version meanwhile ? i.e 3.11 ?
j2cli is unmaintained and no longer works with python3.12. It is therefore replaced with an active fork called jinjanator. The improper use of the '-e' flag on the j2 binary is fixed. Since the env is used as data source there is also no need to import variables explicitly again. Signed-off-by: Felix Matouschek <[email protected]>
maiqueb
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
j2cli is unmaintained and no longer works with python3.12. It is therefore replaced with an active fork called jinjanator.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer (optional):