Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: Update grpc package #184

Closed
wants to merge 1 commit into from
Closed

Conversation

oshoval
Copy link
Member

@oshoval oshoval commented Nov 5, 2023

What this PR does / why we need it:
Handles grpc part of CVE-2023-44487
See GHSA-qppj-fm5r-hxr3

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer (optional):

Signed-off-by: Or Shoval <[email protected]>
@oshoval oshoval requested a review from maiqueb as a code owner November 5, 2023 09:35
@oshoval
Copy link
Member Author

oshoval commented Nov 5, 2023

/cc @0xFelix

@0xFelix
Copy link
Contributor

0xFelix commented Nov 6, 2023

Dup of #178?

@oshoval
Copy link
Member Author

oshoval commented Nov 6, 2023

Dup of #178?

more or less, but this one pass already and we need either one to be merged
it is not biggie which

@maiqueb
Copy link
Collaborator

maiqueb commented Nov 6, 2023

Dup of #178?

more or less, but this one pass already and we need either one to be merged it is not biggie which

Yeah, ended up choosing #178 since it bumps to a later version.

And I'd rather leave updating dependencies to the bot. That's why it's there.

Thanks for keeping tabs on the CVEs though. Appreciate it.

@maiqueb maiqueb closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants