Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2023-3955: Remove unused k8s.io/kubernetes #191

Merged

Conversation

oshoval
Copy link
Member

@oshoval oshoval commented Nov 23, 2023

What this PR does / why we need it:
It was actually not used, and wasn't even vendored.
Hence removed to clean up code and false alarms.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer (optional):
No need to create dedicated release for this imo.

@oshoval oshoval requested a review from maiqueb as a code owner November 23, 2023 10:44
@oshoval
Copy link
Member Author

oshoval commented Nov 23, 2023

linter job failed for the test flakes, not code lint
also e2e failed about known flakes

@oshoval oshoval changed the title CVE-2023-3955: Bump k8s.io/kubernetes CVE-2023-3955: Remove unused k8s.io/kubernetes Nov 23, 2023
@maiqueb
Copy link
Collaborator

maiqueb commented Jan 8, 2024

This PR makes sense.

I would like to merge it after #192 .
Thanks @oshoval

@oshoval
Copy link
Member Author

oshoval commented Jan 8, 2024

/retest

EDIT - too optimistic :)

@oshoval oshoval force-pushed the main_CVE-2023-3955_4c5d1519 branch from 834cdae to 0b0e197 Compare January 8, 2024 11:55
@oshoval
Copy link
Member Author

oshoval commented Jan 8, 2024

rebased

@oshoval oshoval force-pushed the main_CVE-2023-3955_4c5d1519 branch from 0b0e197 to b68777d Compare January 22, 2024 15:42
@oshoval
Copy link
Member Author

oshoval commented Jan 22, 2024

rebased

@maiqueb maiqueb merged commit 3a76a55 into k8snetworkplumbingwg:main Jan 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants