Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump grpc #263

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Bump grpc #263

merged 2 commits into from
Dec 3, 2024

Conversation

maiqueb
Copy link
Collaborator

@maiqueb maiqueb commented Nov 11, 2024

What this PR does / why we need it:
This PR supersedes #261 - it has changes on top to avoid using the deprecated code around the GRPC server.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer (optional):

@maiqueb
Copy link
Collaborator Author

maiqueb commented Nov 11, 2024

@LionelJouin can you review ?

The topmost commit is mine (not from dependabot). I've had to adjust the CRI API connection since what we were using was deprecated (and flagged by the linter as bad).

dependabot bot and others added 2 commits December 2, 2024 12:03
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.33.1 to 1.35.1.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.33.1...v1.35.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Use the new grpc client builder option `WithConnectParams` since the option
`WithBlock` and the client factory function `DialContext` were deprecated.

Signed-off-by: Miguel Duarte Barroso <[email protected]>
@maiqueb maiqueb merged commit 0546691 into main Dec 3, 2024
2 checks passed
@maiqueb maiqueb deleted the bump-grpc branch December 3, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants