Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Upgrade to operator-sdk 0.11.0 and controller-runtime 0.2.0 #369

Merged
merged 4 commits into from
Jan 7, 2020

Conversation

kaczyns
Copy link
Member

@kaczyns kaczyns commented Dec 31, 2019

This was more work than I anticipated. I stepped thru the operator-sdk versions one by one. The first commit gets us to 0.10.0 which was fairly painless. The second commit gets us to 0.11.0. If you're only going to review one of these, review the second one, as that's the more interesting (and also has fewer files to look at, believe it or not). For the most part I followed the operator-sdk upgrade guide and controller-runtime release notes.

First commit:

  • Upgrade to operator-sdk 0.10.0
  • Switch to go modules. Dependencies are now managed as modules. There is no more vendor directory. You can find the modules in $GOPATH/pkg/mods now. The Makefile now prefixes go commands with GO111MODULE=on to force module support.

Second commit:

  • Upgrade to operator-sdk 0.11.0 and controller-runtime 0.2.0
  • controller-runtime webhooks no longer generate their own certificates. Switch to using the OpenShift service certificates. Reading the CA certificate and injecting it into the webhook configuration was fun.
  • operator-sdk and controller-tools have different ideas about what the plural form of kabanero should be, so there are some additional markers (annotations) in the kabanero_types.go file to compensate for this.
  • The CRD file name emitted from operator-sdk changed
  • Lots of little changes where controller-runtime package names and type names changed

@kaczyns
Copy link
Member Author

kaczyns commented Dec 31, 2019

Fixes #250

@kaczyns kaczyns force-pushed the upgradeOperatorSdk branch from d192a17 to 5a2950a Compare January 2, 2020 20:35
Copy link
Collaborator

@mezarin mezarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Built it on my mac. We can remove the use of dep ensure in the Makefile in a separate PR.

@mezarin mezarin merged commit 01887ab into kabanero-io:master Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants