add feature to improve performances by releasing sessions when possible

kalamu · Jan 25, 2019 · faadccd · faadccd
1 parent 0303aaf
commit faadccd
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/Controller/ElementApiController.php b/Controller/ElementApiController.php
@@ -85,6 +85,11 @@ public function infoAction(Request $Request, $context, $type, $name){
     public function renderAction(Request $Request, $context, $type, $name, $format = 'json'){
         $element = $this->getElementManager()->getElement($context, $type, $name);
 
+        if($element->canReleaseSession() && $format !== 'json'){
+            // Release the session because whe don't write in it
+            $Request->getSession()->save();
+        }
+
         $params = array();
         if($element instanceof AbstractConfigurableElement){
             $form = $this->getConfigForm($element, 'show');

diff --git a/Model/AbstractElement.php b/Model/AbstractElement.php
@@ -42,4 +42,18 @@ public function setParameters($parameters){
         $this->parameters = $parameters;
     }
 
+    /**
+     * This method state that this element does not write in session.
+     * When this method return "true", the controller release the session.
+     * This allow concurrent requests witch improve the performances.
+     *
+     * Do not release session if you write on it like when you use forms, flashBag messages, ...
+     *
+     * @return boolean
+     */
+    public function canReleaseSession()
+    {
+        return false;
+    }
+
 }