Add version of FM90 using B3 instead of C3 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 99.64% 99.88% +0.23%
==========================================
Files 8 8
Lines 843 863 +20
==========================================
+ Hits 840 862 +22
+ Misses 3 1 -2 ☔ View full report in Codecov by Sentry. |
karllark
force-pushed
the
add_FM90_B3
branch
from
48e961a to
160facc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FM90 formulation for the bump "strength" is C3. This is not the amplitude. That is C3/gamma^2. For ease of interpretation and fitting, it is better to use the bump amplitude B3 = C3/gamma^2. B3 is then the height of the 2175 A bump. And B3 is not strongly correlated with gamma in the fitting, unlike C3.