Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing pedantic flag #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JiaT75
Copy link
Contributor

@JiaT75 JiaT75 commented Nov 18, 2021

The pedantic flag is not compatible with the FUNCTION macro extension. This fix will remove the warnings generated when compiling.

@lewisporter
Copy link

Danger. The author of this PR is a known malicious actor.

@ZLima12
Copy link

ZLima12 commented Mar 31, 2024

The user has been observed weakening warnings, presumably so that any exploits they create go unnoticed. I wouldn't accept this.

@xealits
Copy link

xealits commented Apr 6, 2024

not only the warnings, the commit 7978e54 "Added configure to .gitignore since it should be regenerated" adds configure and autom4te.cache/ in .gitignore. Autoconf and m4 are arcane things. Is it really sound to move configure outside version control?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants