net/smc: Introduce smc_ops #8312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: 96ea081 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
2db328a to
716c9e0
Compare
|
Upstream branch: 73b9075 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916210=>bpf-next
branch
from
416a723 to
f179551
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
716c9e0 to
c1d981b
Compare
|
Upstream branch: 8c21f88 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916210=>bpf-next
branch
from
f179551 to
e7ebcca
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
c1d981b to
b58ecc3
Compare
|
Upstream branch: 2532608 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916210=>bpf-next
branch
from
e7ebcca to
69cfb6e
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=922409 expired. Closing PR. |
|
Upstream branch: f44275e |
kernel-patches-daemon-bpf
bot
added
new
V5
and removed
changes-requested
V4
V4-ci-fail
labels
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916210=>bpf-next
branch
from
69cfb6e to
4327301
Compare
added 4 commits
January 6, 2025 20:26
Exports three necessary symbols for implementing struct_ops with tristate subsystem. To hold or release refcnt of struct_ops refcnt by inline funcs bpf_try_module_get and bpf_module_put which use bpf_struct_ops_get(put) conditionally. And to copy obj name from one to the other with effective checks by bpf_obj_name_cpy. Signed-off-by: D. Wythe <[email protected]>
The introduction of IPPROTO_SMC enables eBPF programs to determine whether to use SMC based on the context of socket creation, such as network namespaces, PID and comm name, etc. As a subsequent enhancement, to introduce a new generic hook that allows decisions on whether to use SMC or not at runtime, including but not limited to local/remote IP address or ports. Moreover, in the future, we can achieve more complex extensions to the protocol stack by extending this ops. Signed-off-by: D. Wythe <[email protected]>
To implement injection capability for smc via struct_ops, so that user can make their own smc_ops to modify the behavior of smc stack. Currently, user can write their own implememtion to choose whether to use SMC or not before TCP 3rd handshake to be comleted. In the future, users can implement more complex functions on smc by expanding it. Signed-off-by: D. Wythe <[email protected]>
When a struct_ops named xxx_ops was registered by a module, and it will be used in both built-in modules and the module itself, so that the btf_type of xxx_ops will be present in btf_vmlinux instead of in btf_mod, which means that the btf_type of bpf_struct_ops_xxx_ops and xxx_ops will not be in the same btf. Here are four possible case: +--------+-------------+-------------+---------------------------------+ | | st_opx_xxx | xxx | | +--------+-------------+-------------+---------------------------------+ | case 0 | btf_vmlinux | bft_vmlinux | be used and reg only in vmlinux | +--------+-------------+-------------+---------------------------------+ | case 1 | btf_vmlinux | bpf_mod | INVALID | +--------+-------------+-------------+---------------------------------+ | case 2 | btf_mod | btf_vmlinux | reg in mod but be used both in | | | | | vmlinux and mod. | +--------+-------------+-------------+---------------------------------+ | case 3 | btf_mod | btf_mod | be used and reg only in mod | +--------+-------------+-------------+---------------------------------+ At present, cases 0, 1, and 3 can be correctly identified, because st_ops_xxx is searched from the same btf with xxx. In order to handle case 2 correctly without affecting other cases, we cannot simply change the search method for st_ops_xxx from find_btf_by_prefix_kind() to find_ksym_btf_id(), because in this way, case 1 will not be recognized anymore. To address this issue, if st_ops_xxx cannot be found in the btf with xxx and mod_btf does not exist, do find_ksym_btf_id() again to avoid such issue. Fixes: 590a008 ("bpf: libbpf: Add STRUCT_OPS support") Signed-off-by: D. Wythe <[email protected]>
This tests introduces a tiny smc_ops for filtering SMC connections based on IP pairs, and also adds a realistic topology model to verify this ops. Also, we can only use SMC loopback under CI test, so an additional configuration needs to be enabled. Follow the steps below to run this test. make -C tools/testing/selftests/bpf cd tools/testing/selftests/bpf sudo ./test_progs -t smc Results shows: Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED Signed-off-by: D. Wythe <[email protected]>
|
Upstream branch: f44275e |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916210=>bpf-next
branch
from
4327301 to
7626f39
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=922749 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: net/smc: Introduce smc_ops
version: 4
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=922409