selftests/bpf: Fix freplace_link segfault in tailcalls prog test #8387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: c45323b |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
22a0c89 to
828747b
Compare
|
Upstream branch: d0d106a |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/927230=>bpf
branch
from
290ee68 to
efe5d7b
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
828747b to
9b98fe8
Compare
|
Upstream branch: 7569fc9 |
There are two bpf_link__destroy(freplace_link) calls in
test_tailcall_bpf2bpf_freplace(). After the first bpf_link__destroy()
is called, if the following bpf_map_{update,delete}_elem() throws an
exception, it will jump to the "out" label and call bpf_link__destroy()
again, causing double free and eventually leading to a segfault.
Fix it by directly resetting freplace_link to NULL after the first
bpf_link__destroy() call.
Fixes: 021611d ("selftests/bpf: Add test to verify tailcall and freplace restrictions")
Signed-off-by: Tengda Wu <[email protected]>
Reviewed-by: Leon Hwang <[email protected]>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/927230=>bpf
branch
from
efe5d7b to
f48c650
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=927374 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: selftests/bpf: Fix freplace_link segfault in tailcalls prog test
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=927230