Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chart)/probes-timout-per-deploy #84

Merged
merged 6 commits into from
Jan 15, 2025
Merged

feat(chart)/probes-timout-per-deploy #84

merged 6 commits into from
Jan 15, 2025

Conversation

MarcoSaba
Copy link
Contributor

@MarcoSaba MarcoSaba commented Jan 10, 2025 •
edited
Loading

What changes are being made and why?

Bump to version 0.20.12.

Changelog:

  • The healthcheck probes readiness, liveness and startup can now be configured for each single deployment (standalone, worker, scheduler, indexed, executor, webserver)
  • fixed the missing space between server standalone and --worker-thread mentioned in issue 85

How the changes have been QAed?

helm lint and helm template

Setup Instructions

@MarcoSaba MarcoSaba self-assigned this Jan 10, 2025
@MarcoSaba MarcoSaba force-pushed the feat(chart)/probes-timout-per-deploy branch from 54ca0ec to 4ac1afa Compare January 10, 2025 15:28
loicmathieu
loicmathieu approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcoSaba MarcoSaba requested a review from loicmathieu January 13, 2025 09:47
@MarcoSaba MarcoSaba force-pushed the feat(chart)/probes-timout-per-deploy branch from 721170e to b6a191d Compare January 13, 2025 10:09
@MarcoSaba MarcoSaba force-pushed the feat(chart)/probes-timout-per-deploy branch from b6a191d to 05a0063 Compare January 13, 2025 10:11
@MarcoSaba MarcoSaba force-pushed the feat(chart)/probes-timout-per-deploy branch from f82d861 to fd5b892 Compare January 15, 2025 08:25
@MarcoSaba MarcoSaba merged commit 2301fd6 into master Jan 15, 2025
@MarcoSaba MarcoSaba deleted the feat(chart)/probes-timout-per-deploy branch January 15, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchiotludo tchiotludo tchiotludo approved these changes

@loicmathieu loicmathieu Awaiting requested review from loicmathieu

Assignees

@MarcoSaba MarcoSaba

Labels
None yet
Projects
Pull Requests
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoSaba @loicmathieu @tchiotludo