Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): introduce an always block on flow & flowable #6686

Merged
merged 4 commits into from
Jan 13, 2025
Merged

feat(core): introduce an always block on flow & flowable #6686

merged 4 commits into from
Jan 13, 2025

Conversation

tchiotludo
Copy link
Member

close #6649

@loicmathieu
Copy link
Member

loicmathieu commented Jan 8, 2025 •
edited
Loading

I would call it finally as it more clearly convey the fact that it will be done after errors and tasks.
always didn't convey any ordering semantics.

loicmathieu
loicmathieu approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this seems pretty straightforward!

@tchiotludo tchiotludo force-pushed the feat/always branch 2 times, most recently from 02b22d6 to ab7dfed Compare January 9, 2025 18:25
@anna-geller
Copy link
Member

@tchiotludo this is approved by Loic, anything left here before we can merge the finally finally? 😄

@anna-geller anna-geller mentioned this pull request Jan 13, 2025
Open
5 tasks
@tchiotludo
Copy link
Member Author

@anna-geller polishing actually, the topology is not perfect for now

@tchiotludo tchiotludo marked this pull request as ready for review January 13, 2025 16:11
@tchiotludo tchiotludo merged commit 0d1710d into develop Jan 13, 2025
3 checks passed
@tchiotludo tchiotludo deleted the feat/always branch January 13, 2025 16:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
42 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.7% Coverage on New Code
2.4% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pull Requests
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add always (or finally) tasks that run at the end regardless of the final state — useful for cleanup tasks
3 participants
@tchiotludo @loicmathieu @anna-geller