Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MD files #107

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Update MD files #107

merged 2 commits into from
Nov 15, 2024

Conversation

mposolda
Copy link
Contributor

closes #90

@mposolda
Update MD files
173dac8 
closes keycloak#90

Signed-off-by: mposolda <[email protected]>
@mposolda mposolda self-assigned this Nov 14, 2024
rmartinc
rmartinc previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@rmartinc rmartinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mposolda LGTM! Just a little suggestion in a phrase which was confusing to me.

README.md Outdated Show resolved Hide resolved
pskopek
pskopek previously approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@pskopek pskopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM including Ricky's suggestion.

@mposolda @rmartinc
Update README.md
fe58af1 
Co-authored-by: Ricardo Martin <[email protected]>
Signed-off-by: Marek Posolda <[email protected]>
@mposolda mposolda dismissed stale reviews from pskopek and rmartinc via fe58af1 November 15, 2024 07:53
@mposolda
Copy link
Contributor Author

@rmartinc @pskopek Added the suggestion, Thanks!

@mposolda
Copy link
Contributor Author

Thanks everyone for the review!

@mposolda mposolda merged commit b7093b2 into keycloak:main Nov 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graziang graziang graziang approved these changes

@jonkoops jonkoops jonkoops approved these changes

@rmartinc rmartinc rmartinc left review comments

@pskopek pskopek pskopek left review comments

Assignees

@mposolda mposolda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update MD files
5 participants
@mposolda @pskopek @jonkoops @graziang @rmartinc