Add event listener providers #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes keycloak#109 Signed-off-by: mposolda <[email protected]>
jonkoops
approved these changes
Nov 19, 2024
|
@jonkoops Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #109
PR deploys some testsuite providers, so they are available for the server in the testsuite. The provider, which is referenced in the test, caused the test failure.
The keycloak-client should not have any dependency on the Keycloak-server, but it is probably fine to have dependency on the server in the testsuite? Could it be any issue (like productization or something else) why adding dependency on keycloak server artifacts in
testsuite/providerscan cause issues?