Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[milestone]Creating iOS UI #90

Open
augustweinbren opened this issue Apr 11, 2021 · 14 comments
Open

[milestone]Creating iOS UI #90

augustweinbren opened this issue Apr 11, 2021 · 14 comments
Labels
enhancement New feature or request

Comments

@augustweinbren
Copy link

augustweinbren commented Apr 11, 2021

Summary
In order to aid eventual development of an iOS equivalent app, it would be useful to incrementally port the Android UI to Flutter.
This issue will be updated as PRs are planned and submitted.

@augustweinbren augustweinbren added the enhancement New feature or request label Apr 11, 2021
@hpsaturn
Copy link
Member

Thanks August, I'm very new with Flutter, but with any thing that you need I could help.

@hpsaturn
Copy link
Member

Hi @augustweinbren, Google also launched other alternative:

Maybe is a possibility

@augustweinbren
Copy link
Author

Sorry for the delay. I am starting to work on this now.

@augustweinbren augustweinbren changed the title [milestone]Migrating UI to Flutter [milestone]Migrating UI to Kotlin Multiplatform Jul 1, 2021
@augustweinbren
Copy link
Author

Okay, it looks like the conversion of Java code to Kotlin is simpler than the conversion to Flutter, so I think I will take that approach.

@hpsaturn
Copy link
Member

hpsaturn commented Jul 2, 2021

thanks @augustweinbren. If you want I could try to explain the code in a meeting, my english is bad, but I think so that maybe help us. For other side I'm working on extend the documentation here. For now I have not any documentation of code but the idea is work on that.

@augustweinbren
Copy link
Author

Hi @hpsaturn, yes meeting to discuss the current code sounds good. I have sent you an email.

@hpsaturn
Copy link
Member

Hi @augustweinbren sorry for the delay, I had a lot of work, and also this week and the next I'm going to vacation, in two weeks I could make this meeting. Meanwhile I try to leave a class diagram of the Android app architecture to try to advance on this idea. Thanks

@augustweinbren
Copy link
Author

@hpsaturn Ok great, the week of August 9th works for me. Thanks!

@augustweinbren
Copy link
Author

Hi @hpsaturn I have had a look into migrating Java code to Kotlin, and it does not seem too difficult; the Kotlin plugin for IntelliJ can translate the code automatically.

Do you think it would be best to port this code base from Java to Kotlin as a pull request on this repository, or to create a new repository (say canairio_multiplatform)?

Creating a new repository sounds a little better to me, but the one concern I have is about the functionality/UI of canairio_android and canairio_multiplatform diverging.

@hpsaturn
Copy link
Member

hpsaturn commented Sep 2, 2021

@augustweinbren so sorry for don't re-planning the meeting with you. About your questions, I think that is better a Pull Request here, because for community reason, commits history, and contributions of others and me, the repository should be here. For other side, if the new branch is stable and works fine, I think that we should have not problems in the future making a merge. What do you think?

@augustweinbren
Copy link
Author

@hpsaturn That sounds good! I will make a pull request on master when I have converted the code to be shared between apps to Kotlin.

@hpsaturn
Copy link
Member

hpsaturn commented Sep 2, 2021

Thanks again, if you maybe need a pair programing session or maybe do you have any question, please let me know

@augustweinbren augustweinbren changed the title [milestone]Migrating UI to Kotlin Multiplatform [milestone]Creating iOS UI Sep 10, 2021
@augustweinbren
Copy link
Author

augustweinbren commented Sep 10, 2021

I've done a bit more research, and it looks actually like using Multi-OS-Engine would be the most straightforward approach to creating an iOS app from an already-developed Android app (i.e. it does not require porting code from Java to Kotlin). I have transferred the Models folder in the app module to a commons module and will next work on transferring the API folder.

@hpsaturn
Copy link
Member

wow, it sounds really good. If you need maybe resolve some questions or more explanation from my undocumented code, please let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants