Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-OS Engine support + moving of generic Java code to commons #110

Merged
merged 5 commits into from
Sep 14, 2021

Conversation

augustweinbren
Copy link

Description

This PR does not modify any existing behavior. It consists of the following changes:

  • Support for Multi-OS Engine added to build.gradle
  • commons(to consist of shared iOS/android code) and ios modules created.
  • Boiler plate code for ios module automatically generated.
  • Models package + parts of API package which do not use Android libraries moved to commons module.

Related Issues

[#90] (note: this PR should not close the issue.)

@augustweinbren
Copy link
Author

Although the Android app builds successfully, I am currently seeing the following error message when running the app.

E/FirebaseCrashlytics: Settings request failed.
java.io.FileNotFoundException: https://firebase-settings.crashlytics.com/spi/v2/platforms/android/gmp/1:460393230596:android:a4512316c4b07001132051/settings?instance=d2ce15d64f057f5a768d8a0187b20776f9e4e11b&build_version=581&display_version=0.7.0&source=1
at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:255)
at com.android.okhttp.internal.huc.DelegatingHttpsURLConnection.getInputStream(DelegatingHttpsURLConnection.java:211)
at com.android.okhttp.internal.huc.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:30)
at com.google.firebase.crashlytics.internal.network.HttpGetRequest.execute(HttpGetRequest.java:80)
at com.google.firebase.crashlytics.internal.settings.network.DefaultSettingsSpiCall.invoke(DefaultSettingsSpiCall.java:113)
at com.google.firebase.crashlytics.internal.settings.SettingsController$1.then(SettingsController.java:199)
at com.google.firebase.crashlytics.internal.settings.SettingsController$1.then(SettingsController.java:192)
at com.google.android.gms.tasks.zzo.run(com.google.android.gms:play-services-tasks@@17.2.0:2)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at com.google.firebase.crashlytics.internal.common.ExecutorUtils$1$1.onRun(ExecutorUtils.java:64)
at com.google.firebase.crashlytics.internal.common.BackgroundPriorityRunnable.run(BackgroundPriorityRunnable.java:27)
at java.lang.Thread.run(Thread.java:923)

@augustweinbren augustweinbren changed the title Feature/ios UI Multi-OS Engine support + moving of generic Java code to commons Sep 11, 2021
@hpsaturn
Copy link
Member

hpsaturn commented Sep 13, 2021

Thanks @augustweinbren I'm going to test and review it..

@hpsaturn hpsaturn changed the base branch from master to devel September 13, 2021 11:02
Copy link
Member

@hpsaturn hpsaturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, for now it build ok and works ok in a first review, I have only one request. For other side I changed the pull request target branch to devel.

settings.gradle Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants