-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-OS Engine support + moving of generic Java code to commons #110
Conversation
Builds, but following error message occurs when simulating android app: E/FirebaseCrashlytics: Settings request failed. java.io.FileNotFoundException: https://firebase-settings.crashlytics.com/spi/v2/platforms/android/gmp/1:460393230596:android:a4512316c4b07001132051/settings?instance=d2ce15d64f057f5a768d8a0187b20776f9e4e11b&build_version=581&display_version=0.7.0&source=1
Although the Android app builds successfully, I am currently seeing the following error message when running the app. E/FirebaseCrashlytics: Settings request failed. |
Thanks @augustweinbren I'm going to test and review it.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, for now it build ok and works ok in a first review, I have only one request. For other side I changed the pull request target branch to devel.
Description
This PR does not modify any existing behavior. It consists of the following changes:
commons
(to consist of shared iOS/android code) andios
modules created.ios
module automatically generated.Models
package + parts ofAPI
package which do not use Android libraries moved tocommons
module.Related Issues
[#90] (note: this PR should not close the issue.)