Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use bytes for addresses ids an remove _derived* fields #32

Merged
merged 1 commit into from
Oct 24, 2023
Merged

feat: use bytes for addresses ids an remove _derived* fields #32

merged 1 commit into from
Oct 24, 2023

Conversation

gauthiermyr
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Oct 24, 2023

ETH-400 Remove _derived* fields and use bytes as ids for contracts and users entities

Fixed an issue where derived loaders were not working with entities with Bytes as IDs

Derived fields getter: Derived fields can now be accessed from within the mapping code during indexing

@gauthiermyr gauthiermyr requested a review from mortimr October 24, 2023 09:12
mortimr
mortimr approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@mortimr mortimr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, next step would be to test the Ledger Dapp on testnet with the new subgraph

@gauthiermyr gauthiermyr merged commit 8f8c2a1 into master Oct 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortimr mortimr mortimr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gauthiermyr @mortimr