#21 Migrating Volto Heading Block addon to new project-less setup #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cept/volto-heading-block into #21-volto-heading-block-Migration
sneridagh
requested changes
Jan 16, 2025
There was a problem hiding this comment.
There are some root files that have content that need to be merged with the ones coming from the add-on scaffolding. Others were just deleted: (LICENSE, CONTRIBUTORS) please bring them back and merge the information when needed.
Also, the versions have to be maintained both in the root and in the inner package.
|
@sneridagh , I have tried to merge the content of some root files from old which I thought were important. Please tell if some files have missing content still. And added the LICENSE & CONTRIBUTORS.md. |
sneridagh
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.