Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

Commit

Permalink
Add static OOG for all opcodes (#801)
Browse files Browse the repository at this point in the history
Time spent on this PR: 0.4

## Pull request type

Please check the type of change your PR introduces:

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [x] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?

Some opcode families defines their own `opcode_label`.
OOG and Stack over/underflow are defined at the opcode of family level.

## What is the new behavior?

One single `opcode_label` constant is defined and used everywhere.
OOG and Stack over/underflow are defined at the `exec_opcode` level.

Resolves: #777
  • Loading branch information
ClementWalter authored Nov 7, 2023
1 parent 63e8569 commit 4277d5f
Show file tree
Hide file tree
Showing 24 changed files with 1,672 additions and 722 deletions.
4 changes: 2 additions & 2 deletions src/kakarot/account.cairo
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ from starkware.cairo.common.hash_state import (
hash_update_with_hashchain,
)

from kakarot.constants import (
Constants,
from kakarot.constants import Constants
from kakarot.storages import (
account_proxy_class_hash,
native_token_address,
contract_account_class_hash,
Expand Down
Loading

0 comments on commit 4277d5f

Please sign in to comment.