Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

feat: blobbasefee return ONE #1442

Merged
merged 2 commits into from
Sep 25, 2024
Merged

feat: blobbasefee return ONE #1442

merged 2 commits into from
Sep 25, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 25, 2024

BLOBBASEFEE should return the MIN_BASE_FEE_PER_BLOB_GAS defined in https://eips.ethereum.org/EIPS/eip-4844#gas-accounting instead of Zero.


This change is Reviewable

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.9%. Comparing base (2b57e60) to head (5776a2e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1442     +/-   ##
=======================================
- Coverage   61.9%   61.9%   -0.1%     
=======================================
  Files         44      44             
  Lines       8169    8169             
=======================================
- Hits        5062    5061      -1     
- Misses      3107    3108      +1     
Flag Coverage Δ
61.9% <100.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enitrat enitrat merged commit ad40c50 into main Sep 25, 2024
10 checks passed
@enitrat enitrat deleted the feat/blobbasefee-min-1 branch September 25, 2024 10:27
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
* AccountManager: implement start_nonce_updater

* bump kakarot

* Update src/pool/mempool.rs

Co-authored-by: greged93 <[email protected]>

---------

Co-authored-by: greged93 <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants