Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

Commit account iif it has code or nonce #802

Merged

Conversation

ClementWalter
Copy link
Member

Time spent on this PR: 0.1

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When an account is not registered, it's deployed as a CA in commit in any cases.

Resolves #793

What is the new behavior?

A contract is deployed only if it has code or nonce.

Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (63e8569) 68.77% compared to head (527da5d) 71.24%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
+ Coverage   68.77%   71.24%   +2.47%     
==========================================
  Files          45       45              
  Lines        6286     5933     -353     
==========================================
- Hits         4323     4227      -96     
+ Misses       1963     1706     -257     
Files Coverage Δ
src/kakarot/evm.cairo 100.00% <ø> (ø)
.../kakarot/instructions/duplication_operations.cairo 100.00% <ø> (+34.61%) ⬆️
...karot/instructions/environmental_information.cairo 100.00% <100.00%> (+11.53%) ⬆️
src/kakarot/instructions/exchange_operations.cairo 100.00% <ø> (+28.57%) ⬆️
src/kakarot/instructions/push_operations.cairo 100.00% <ø> (+21.42%) ⬆️
...akarot/instructions/stop_and_math_operations.cairo 94.42% <ø> (+20.65%) ⬆️
src/kakarot/instructions/system_operations.cairo 87.05% <ø> (+2.96%) ⬆️
src/kakarot/library.cairo 24.69% <ø> (ø)
src/kakarot/precompiles/precompiles.cairo 59.52% <ø> (-0.48%) ⬇️
src/kakarot/state.cairo 85.02% <ø> (ø)
... and 3 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementWalter ClementWalter merged commit a396881 into kkrt-labs:main Nov 7, 2023
6 of 7 checks passed
@ClementWalter ClementWalter deleted the cw/account-commit-no-empty branch November 7, 2023 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: commit account should not always deploy a new account
2 participants